Skip to content

Commit f0dc118

Browse files
committed
Fix StyleCI 7.0 error; fix route url bindings
1 parent 20b2b7f commit f0dc118

File tree

3 files changed

+12
-9
lines changed

3 files changed

+12
-9
lines changed

.styleci.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,6 @@ enabled:
44
- phpdoc_order
55
- phpdoc_separation
66
- unalign_double_arrow
7+
8+
disabled:
9+
- short_list_syntax

src/Commands/GenerateDocumentation.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ private function isValidRoute(Route $route)
237237
*/
238238
private function isRouteVisibleForDocumentation($route)
239239
{
240-
[$class, $method] = explode('@', $route);
240+
list($class, $method) = explode('@', $route);
241241
$reflection = new ReflectionClass($class);
242242

243243
if (! $reflection->hasMethod($method)) {

src/Tools/Generator.php

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public function getMethods(Route $route)
5454
public function processRoute(Route $route, array $rulesToApply = [])
5555
{
5656
$routeAction = $route->getAction();
57-
[$class, $method] = explode('@', $routeAction['uses']);
57+
list($class, $method) = explode('@', $routeAction['uses']);
5858
$controller = new ReflectionClass($class);
5959
$method = $controller->getMethod($method);
6060

@@ -75,7 +75,7 @@ public function processRoute(Route $route, array $rulesToApply = [])
7575
'description' => $docBlock['long'],
7676
'methods' => $this->getMethods($route),
7777
'uri' => $this->getUri($route),
78-
'boundUri' => Utils::getFullUrl($route, $rulesToApply['bindings'] ?? []),
78+
'boundUri' => Utils::getFullUrl($route, $rulesToApply['bindings'] ?? ($rulesToApply['response_calls']['bindings'] ?? [])),
7979
'queryParameters' => $queryParameters,
8080
'bodyParameters' => $bodyParameters,
8181
'cleanBodyParameters' => $this->cleanParams($bodyParameters),
@@ -135,11 +135,11 @@ protected function getBodyParametersFromDocBlock(array $tags)
135135
preg_match('/(.+?)\s+(.+?)\s+(required\s+)?(.*)/', $tag->getContent(), $content);
136136
if (empty($content)) {
137137
// this means only name and type were supplied
138-
[$name, $type] = preg_split('/\s+/', $tag->getContent());
138+
list($name, $type) = preg_split('/\s+/', $tag->getContent());
139139
$required = false;
140140
$description = '';
141141
} else {
142-
[$_, $name, $type, $required, $description] = $content;
142+
list($_, $name, $type, $required, $description) = $content;
143143
$description = trim($description);
144144
if ($description == 'required' && empty(trim($required))) {
145145
$required = $description;
@@ -149,7 +149,7 @@ protected function getBodyParametersFromDocBlock(array $tags)
149149
}
150150

151151
$type = $this->normalizeParameterType($type);
152-
[$description, $example] = $this->parseDescription($description, $type);
152+
list($description, $example) = $this->parseDescription($description, $type);
153153
$value = is_null($example) ? $this->generateDummyValue($type) : $example;
154154

155155
return [$name => compact('type', 'description', 'required', 'value')];
@@ -210,11 +210,11 @@ protected function getQueryParametersFromDocBlock(array $tags)
210210
preg_match('/(.+?)\s+(required\s+)?(.*)/', $tag->getContent(), $content);
211211
if (empty($content)) {
212212
// this means only name was supplied
213-
[$name] = preg_split('/\s+/', $tag->getContent());
213+
list($name) = preg_split('/\s+/', $tag->getContent());
214214
$required = false;
215215
$description = '';
216216
} else {
217-
[$_, $name, $required, $description] = $content;
217+
list($_, $name, $required, $description) = $content;
218218
$description = trim($description);
219219
if ($description == 'required' && empty(trim($required))) {
220220
$required = $description;
@@ -223,7 +223,7 @@ protected function getQueryParametersFromDocBlock(array $tags)
223223
$required = trim($required) == 'required' ? true : false;
224224
}
225225

226-
[$description, $value] = $this->parseDescription($description, 'string');
226+
list($description, $value) = $this->parseDescription($description, 'string');
227227
if (is_null($value)) {
228228
$value = str_contains($description, ['number', 'count', 'page'])
229229
? $this->generateDummyValue('integer')

0 commit comments

Comments
 (0)