Fix version comparisons

shalvah · shalvah · commit 0e60a1d3e111 · 2018-10-08T18:25:13.000+01:00
diff --git a/tests/DingoGeneratorTest.php b/tests/DingoGeneratorTest.php
@@ -37,8 +37,8 @@ public function setUp()
 
     public function testCanParseMethodDescription()
     {
-        if (version_compare($this->app->version(), '5.4', '>=')) {
-            $this->markTestSkipped('Dingo does not support Laravel 5.4');
+        if (version_compare($this->app->version(), '5.4', '<=')) {
+            $this->markTestSkipped('Dingo does not support Laravel 5.4 or below');
         }
 
         $api = app('Dingo\Api\Routing\Router');
@@ -55,8 +55,8 @@ public function testCanParseMethodDescription()
 
     public function testCanParseRouteMethods()
     {
-        if (version_compare($this->app->version(), '5.4', '>=')) {
-            $this->markTestSkipped('Dingo does not support Laravel 5.4');
+        if (version_compare($this->app->version(), '5.4', '<=')) {
+            $this->markTestSkipped('Dingo does not support Laravel 5.4 or below');
         }
 
         $api = app('Dingo\Api\Routing\Router');
@@ -85,8 +85,8 @@ public function testCanParseRouteMethods()
 
     public function testCanParseFormRequestRules()
     {
-        if (version_compare($this->app->version(), '5.4', '>=')) {
-            $this->markTestSkipped('Dingo does not support Laravel 5.4');
+        if (version_compare($this->app->version(), '5.4', '<=')) {
+            $this->markTestSkipped('Dingo does not support Laravel 5.4 or below');
         }
 
         $api = app('Dingo\Api\Routing\Router');
diff --git a/tests/GenerateDocumentationTest.php b/tests/GenerateDocumentationTest.php
@@ -84,8 +84,8 @@ public function testConsoleCommandDoesNotWorkWithClosure()
 
     public function testConsoleCommandDoesNotWorkWithClosureUsingDingo()
     {
-        if (version_compare($this->app->version(), '5.4', '>=')) {
-            $this->markTestSkipped('Dingo does not support Laravel 5.4');
+        if (version_compare($this->app->version(), '5.4', '<=')) {
+            $this->markTestSkipped('Dingo does not support Laravel 5.4 or below');
         }
 
         $api = app('Dingo\Api\Routing\Router');

Original file line number	Diff line number	Diff line change
`@@ -37,8 +37,8 @@ public function setUp()`
`37`	`37`
`38`	`38`	`public function testCanParseMethodDescription()`
`39`	`39`	`{`
`40`		`- if (version_compare($this->app->version(), '5.4', '>=')) {`
`41`		`- $this->markTestSkipped('Dingo does not support Laravel 5.4');`
	`40`	`+ if (version_compare($this->app->version(), '5.4', '<=')) {`
	`41`	`+ $this->markTestSkipped('Dingo does not support Laravel 5.4 or below');`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`$api = app('Dingo\Api\Routing\Router');`
`@@ -55,8 +55,8 @@ public function testCanParseMethodDescription()`
`55`	`55`
`56`	`56`	`public function testCanParseRouteMethods()`
`57`	`57`	`{`
`58`		`- if (version_compare($this->app->version(), '5.4', '>=')) {`
`59`		`- $this->markTestSkipped('Dingo does not support Laravel 5.4');`
	`58`	`+ if (version_compare($this->app->version(), '5.4', '<=')) {`
	`59`	`+ $this->markTestSkipped('Dingo does not support Laravel 5.4 or below');`
`60`	`60`	`}`
`61`	`61`
`62`	`62`	`$api = app('Dingo\Api\Routing\Router');`
`@@ -85,8 +85,8 @@ public function testCanParseRouteMethods()`
`85`	`85`
`86`	`86`	`public function testCanParseFormRequestRules()`
`87`	`87`	`{`
`88`		`- if (version_compare($this->app->version(), '5.4', '>=')) {`
`89`		`- $this->markTestSkipped('Dingo does not support Laravel 5.4');`
	`88`	`+ if (version_compare($this->app->version(), '5.4', '<=')) {`
	`89`	`+ $this->markTestSkipped('Dingo does not support Laravel 5.4 or below');`
`90`	`90`	`}`
`91`	`91`
`92`	`92`	`$api = app('Dingo\Api\Routing\Router');`
Original file line number	Diff line number	Diff line change
`@@ -84,8 +84,8 @@ public function testConsoleCommandDoesNotWorkWithClosure()`
`84`	`84`
`85`	`85`	`public function testConsoleCommandDoesNotWorkWithClosureUsingDingo()`
`86`	`86`	`{`
`87`		`- if (version_compare($this->app->version(), '5.4', '>=')) {`
`88`		`- $this->markTestSkipped('Dingo does not support Laravel 5.4');`
	`87`	`+ if (version_compare($this->app->version(), '5.4', '<=')) {`
	`88`	`+ $this->markTestSkipped('Dingo does not support Laravel 5.4 or below');`
`89`	`89`	`}`
`90`	`90`
`91`	`91`	`$api = app('Dingo\Api\Routing\Router');`