diff --git a/CHANGELOG.md b/CHANGELOG.md index 67a26e91..32456718 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,8 @@ ## Unreleased +- Swift: Fix argument labels in labeled *distributions ([#859](https://github.com/mozilla/glean_parser/issues/859)) + ## 21.0.0 - BREAKING CHANGE: Generate labeled {custom|memory|timing} distribution for mobile ([#857](https://github.com/mozilla/glean_parser/pull/857)) diff --git a/glean_parser/templates/swift.jinja2 b/glean_parser/templates/swift.jinja2 index eb8cfc85..d23c2bb6 100644 --- a/glean_parser/templates/swift.jinja2 +++ b/glean_parser/templates/swift.jinja2 @@ -227,7 +227,7 @@ extension {{ namespace }} { disabled: {{ obj.is_disabled()|swift }}, ) {% for arg_name in extra_metric_args if obj[arg_name] is defined %} - , {{ obj[arg_name]|swift }} + , {{arg_name|camelize}}: {{ obj[arg_name]|swift }} {% endfor %} ), {% elif obj.type == "labeled_memory_distribution" %} @@ -240,7 +240,11 @@ extension {{ namespace }} { disabled: {{ obj.is_disabled()|swift }}, ) {% for arg_name in extra_metric_args if obj[arg_name] is defined %} - , {{ obj[arg_name]|swift }} + {% if arg_name == "memory_unit" %} + , unit: {{ obj[arg_name]|swift }} + {% else %} + , {{arg_name|camelize}}: {{ obj[arg_name]|swift }} + {% endif %} {% endfor %} ), {% elif obj.type == "labeled_timing_distribution" %} @@ -253,7 +257,11 @@ extension {{ namespace }} { disabled: {{ obj.is_disabled()|swift }}, ) {% for arg_name in extra_metric_args if obj[arg_name] is defined %} - , {{ obj[arg_name]|swift }} + {% if arg_name == "time_unit" %} + , unit: {{ obj[arg_name]|swift }} + {% else %} + , {{arg_name|camelize}}: {{ obj[arg_name]|swift }} + {% endif %} {% endfor %} ), {% elif obj.labeled %} @@ -266,7 +274,7 @@ extension {{ namespace }} { disabled: {{ obj.is_disabled()|swift }}, ) {% for arg_name in extra_metric_args if obj[arg_name] is defined %} - , {{ obj[arg_name]|swift }} + , {{arg_name|camelize}}: {{ obj[arg_name]|swift }} {% endfor %} ), {% else %}