Skip to content

Commit a64e80e

Browse files
rvandermeulenjonalmeida
authored andcommitted
Align RB Detekt rules with firefox-main
1 parent b66e982 commit a64e80e

File tree

1 file changed

+14
-12
lines changed

1 file changed

+14
-12
lines changed

config/detekt.yml

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Please refer to https://github.com/mozilla-mobile/firefox-android/blob/main/android-components/config/detekt.yml
1+
# Please refer to https://raw.githubusercontent.com/mozilla-firefox/firefox/main/mobile/android/android-components/config/detekt.yml
22
# for the source of truth for our detekt configuration.
33

44
build:
@@ -56,7 +56,7 @@ output-reports:
5656
comments:
5757
active: true
5858
AbsentOrWrongFileLicense:
59-
active: true # Enabled in https://bugzilla.mozilla.org/show_bug.cgi?id=1795140
59+
active: true
6060
licenseTemplateFile: 'license.template'
6161
licenseTemplateIsRegex: false
6262
CommentOverPrivateFunction:
@@ -72,8 +72,8 @@ comments:
7272
active: false
7373
excludes: ['**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/androidUnitTest/**', '**/androidInstrumentedTest/**', '**/jsTest/**', '**/iosTest/**']
7474
OutdatedDocumentation:
75-
active: false
76-
matchTypeParameters: true
75+
active: true # Enabled in https://bugzilla.mozilla.org/show_bug.cgi?id=1848527
76+
matchTypeParameters: false # (Default: true) Disabled in https://bugzilla.mozilla.org/show_bug.cgi?id=1848527
7777
matchDeclarationsOrder: true
7878
allowParamOnConstructorProperties: false
7979
UndocumentedPublicClass:
@@ -84,6 +84,7 @@ comments:
8484
searchInInnerObject: true
8585
searchInInnerInterface: true
8686
searchInProtectedClass: false
87+
ignoreDefaultCompanionObject: true
8788
UndocumentedPublicFunction:
8889
active: true # Enabled in https://github.com/mozilla-mobile/android-components/issues/76
8990
excludes: ['**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/androidUnitTest/**', '**/androidInstrumentedTest/**', '**/jsTest/**', '**/iosTest/**']
@@ -134,7 +135,7 @@ complexity:
134135
threshold: 75 # (Default: 60) Increased in https://github.com/mozilla-mobile/android-components/issues/6350
135136
LongParameterList:
136137
active: true
137-
functionThreshold: 6
138+
functionThreshold: 8 # (Default: 6) Increased in https://bugzilla.mozilla.org/show_bug.cgi?id=1872996
138139
constructorThreshold: 7
139140
ignoreDefaultParameters: true # Enabled in https://github.com/mozilla-mobile/android-components/issues/10835
140141
ignoreDataClasses: true
@@ -178,6 +179,7 @@ complexity:
178179
ignoreDeprecated: false
179180
ignorePrivate: false
180181
ignoreOverridden: false
182+
ignoreAnnotatedFunctions: []
181183

182184
coroutines:
183185
active: true
@@ -596,8 +598,8 @@ style:
596598
- reason: 'println does not allow you to configure the output stream. Use a logger instead.'
597599
value: 'kotlin.io.println'
598600
ForbiddenSuppress:
599-
active: false
600-
rules: []
601+
active: true
602+
rules: ['LongMethod', 'ComplexMethod', 'MagicNumber']
601603
ForbiddenVoid:
602604
active: false # (Default: true)
603605
ignoreOverridden: false
@@ -618,14 +620,16 @@ style:
618620
- '0'
619621
- '1'
620622
- '2'
623+
- '60' # seconds in minute / minutes in hour
624+
- '1000' # millis in second
621625
ignoreHashCodeFunction: true
622626
ignorePropertyDeclaration: true # Enabled for Compose in https://github.com/mozilla-mobile/android-components/issues/11864
623-
ignoreLocalVariableDeclaration: false
627+
ignoreLocalVariableDeclaration: true
624628
ignoreConstantDeclaration: true
625629
ignoreCompanionObjectPropertyDeclaration: true
626630
ignoreAnnotation: false
627631
ignoreNamedArgument: true
628-
ignoreEnums: false
632+
ignoreEnums: true
629633
ignoreRanges: false
630634
ignoreExtensionFunctions: true
631635
MandatoryBracesLoops:
@@ -733,7 +737,7 @@ style:
733737
UntilInsteadOfRangeTo:
734738
active: false
735739
UnusedImports:
736-
active: false
740+
active: true
737741
UnusedParameter:
738742
active: true
739743
allowedNames: 'ignored|expected'
@@ -785,5 +789,3 @@ style:
785789
ignoreLateinitVar: false
786790
WildcardImport:
787791
active: true
788-
excludeImports:
789-
- 'java.util.*'

0 commit comments

Comments
 (0)