From e16a85c887da0144308926eb138476686f3284e8 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Fri, 13 Nov 2026 06:47:05 -0800 Subject: [PATCH 1/4] quest: plan rejecting Required links to a later milestone Co-Authored-By: Claude Opus 5.5 --- quest/m0/milestone-order.md | 45 +++++++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) create mode 100644 quest/m0/milestone-order.md diff --git a/quest/m0/milestone-order.md b/quest/m0/milestone-order.md new file mode 100644 index 00000000..39ed8651 --- /dev/null +++ b/quest/m0/milestone-order.md @@ -0,0 +1,45 @@ +# [S] Reject Required links to a later milestone + +## Goal + +`quest check` fails on a `Required` entry whose target sits in a later +milestone than the document listing it, such as an m1 quest requiring an m2 +one. The finding names both documents and their milestones, and says to move +one of them with `quest mv`. Quests, epic READMEs, and milestone READMEs are +all covered; the root README, which belongs to no milestone, and links to +other repositories are not. + +`quest unblocked` ranks a blocker by its own milestone, so an inverted link +leaves the earlier quest stalled behind all of the later milestone's work. On +2026-11-13, moq-dev/moq's main held six such links, moq.pro's one, and rind's +one. + +## Plan + +Decided 2026-11-13 (user, /quest-plan): + +- How is an inverted link prevented? + - ✅ `quest check` rejects it (recommended): the tree then states each + quest's real priority, and `/quest-audit` no longer has to spot it by eye + (rejected: ranking a blocker at its dependents' earliest milestone instead, + which hides the misplaced quest; both, which is redundant once check holds) +- Milestone? + - ✅ m0 (recommended): it fixes stalls in moq-dev's own repositories (rejected: + m1, m2) +- What about the links already on main in moq, moq.pro, and rind? + - ✅ Fix them now, in one PR per repository, before this rule ships + (rejected: list them here and leave them to each repository's pin bump) + +Implementation guidance: + +- A document's milestone is the root child directory that holds it, ordered + as `quest unblocked` orders milestones, so `m10` follows `m9`. +- There is no `--fix`: which side moves is a priority decision for the + maintainer, as `/quest-audit` already treats moving a quest between + milestones. +- Every check finding also makes `quest unblocked` and `quest start` fail, so + a repository whose tree holds an inverted link cannot rank work until it + fixes it. That is intended; the fixes above clear moq-dev's trees first. +- Update the guide's `Required` rules in `assets/AGENTS.md` beside + "`Required` must be acyclic", and narrow `/quest-audit`'s "misaligned + priorities" item in `assets/skills/audit.md` to what check cannot see. From 8c4fd5662b3c73fa4585d4781b54265d1575766a Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Fri, 13 Nov 2026 06:58:28 -0800 Subject: [PATCH 2/4] quest: name the PRs that clear existing inverted links Co-Authored-By: Claude Opus 5.5 --- quest/m0/milestone-order.md | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/quest/m0/milestone-order.md b/quest/m0/milestone-order.md index 39ed8651..a477ae7b 100644 --- a/quest/m0/milestone-order.md +++ b/quest/m0/milestone-order.md @@ -28,7 +28,13 @@ Decided 2026-11-13 (user, /quest-plan): m1, m2) - What about the links already on main in moq, moq.pro, and rind? - ✅ Fix them now, in one PR per repository, before this rule ships - (rejected: list them here and leave them to each repository's pin bump) + (rejected: list them here and leave them to each repository's pin bump): + [moq-dev/moq#8645](https://github.com/moq-dev/moq/pull/8645) and + [moq-dev/moq.pro#3992](https://github.com/moq-dev/moq.pro/pull/3992). + rind's one link goes when + [kixel-ai/rind#606](https://github.com/kixel-ai/rind/pull/606) merges + and deletes the quest it points to. Before this rule ships, re-scan + each repository's main for links added since. Implementation guidance: From a58598999454a922659ab05e4e00423f6137288b Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Fri, 13 Nov 2026 08:01:28 -0800 Subject: [PATCH 3/4] quest: record the kind-split challenge, and fix moq's links in its audit PR Co-Authored-By: Claude Opus 5.5 --- quest/m0/milestone-order.md | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/quest/m0/milestone-order.md b/quest/m0/milestone-order.md index a477ae7b..f061ab20 100644 --- a/quest/m0/milestone-order.md +++ b/quest/m0/milestone-order.md @@ -29,8 +29,16 @@ Decided 2026-11-13 (user, /quest-plan): - What about the links already on main in moq, moq.pro, and rind? - ✅ Fix them now, in one PR per repository, before this rule ships (rejected: list them here and leave them to each repository's pin bump): - [moq-dev/moq#8645](https://github.com/moq-dev/moq/pull/8645) and + [moq-dev/moq#8637](https://github.com/moq-dev/moq/pull/8637), the + pre-cut audit, which supersedes the closed moq-dev/moq#8645, and [moq-dev/moq.pro#3992](https://github.com/moq-dev/moq.pro/pull/3992). +- Challenged the same day: moq splits m1 and m2 by kind, not priority, and + its 2026-11-12 audit kept additive m1 quests requiring breaking m2 work on + purpose. Should ranking instead give a blocker its dependents' earliest + milestone? + - ✅ Keep the check rule (user: "I definitely don't want earlier milestones + blocked on later milestones") (rejected: ranking inheritance instead; + both). moq moves those quests to m3. rind's one link goes when [kixel-ai/rind#606](https://github.com/kixel-ai/rind/pull/606) merges and deletes the quest it points to. Before this rule ships, re-scan From 776e8ee8498997ecebfb71cb9d88e2a9d2b4f824 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Fri, 13 Nov 2026 13:30:51 -0800 Subject: [PATCH 4/4] Name remedies a permanent milestone allows in the milestone-order finding Co-Authored-By: Claude Opus 5.5 --- quest/m0/milestone-order.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/quest/m0/milestone-order.md b/quest/m0/milestone-order.md index f061ab20..bf0abb63 100644 --- a/quest/m0/milestone-order.md +++ b/quest/m0/milestone-order.md @@ -5,7 +5,10 @@ `quest check` fails on a `Required` entry whose target sits in a later milestone than the document listing it, such as an m1 quest requiring an m2 one. The finding names both documents and their milestones, and says to move -one of them with `quest mv`. Quests, epic READMEs, and milestone READMEs are +the later quest or epic earlier with `quest mv`, or remove the link. A +milestone README cannot move, since milestones are permanent, so when either +side is one the finding offers only moving the quest or epic on the other +side, or removing the link. Quests, epic READMEs, and milestone READMEs are all covered; the root README, which belongs to no milestone, and links to other repositories are not.