Skip to content

Commit 7157c01

Browse files
committed
Moved comments
1 parent f1cf707 commit 7157c01

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

source/sessions/snapshot-sessions.md

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -124,11 +124,6 @@ Note that the `snapshotTime` property is optional. The default value of this pro
124124

125125
Client MUST throw an error if `snapshotTime` is set and `snapshot` is not set to true.
126126

127-
Note that when parsing `snapshotTime` from `sessionOptions` for
128-
[unified tests](https://github.com/mongodb/specifications/blob/master/source/unified-test-format/unified-test-format.md),
129-
the parsed string is the name of the key for the actual value of `snapshotTime` to be found in the
130-
[entity map](https://github.com/mongodb/specifications/blob/master/source/unified-test-format/unified-test-format.md#entity-map).
131-
132127
## ClientSession changes
133128

134129
A readonly property called `snapshotTime` will be added to `ClientSession` that allows applications to retrieve the
@@ -147,10 +142,6 @@ Getting the value of `snapshotTime` on a non-snapshot session MUST raise an erro
147142
Transactions are not allowed with snapshot sessions. Calling `session.startTransaction(options)` on a snapshot session
148143
MUST raise an error.
149144

150-
Note that a new operation on session called `getSnapshotTime` must be supported for
151-
[unified tests](https://github.com/mongodb/specifications/blob/master/source/unified-test-format/unified-test-format.md).
152-
This operation returns the value of `snapshotTime` on the session, so that it can be used in following operations.
153-
154145
## ReadConcern changes
155146

156147
`snapshot` added to [ReadConcernLevel enumeration](../read-write-concern/read-write-concern.md#read-concern).

source/sessions/tests/README.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,15 @@ As part of the test setup for these cases, create a `MongoClient` pointed at the
2929
in the test case and verify that the test server does NOT define a value for `logicalSessionTimeoutMinutes` by sending a
3030
hello command and checking the response.
3131

32+
## Specific operations and behaviour for unified tests
33+
34+
An operation on sessions called `getSnapshotTime` must be supported for unified tests. This operation returns the value
35+
of `snapshotTime` on the session, so that it can be used in subsequent operations.
36+
37+
When parsing `snapshotTime` from `sessionOptions` for unified tests, the parsed string is the name of the key for the
38+
actual value of `snapshotTime` to be found in the
39+
[entity map](https://github.com/mongodb/specifications/blob/master/source/unified-test-format/unified-test-format.md#entity-map).
40+
3241
## Prose tests
3342

3443
### 1. Setting both `snapshot` and `causalConsistency` to true is not allowed

0 commit comments

Comments
 (0)