From 9e419e7c2fc146f77b017a53ad416efaad9438cf Mon Sep 17 00:00:00 2001 From: bailey Date: Mon, 1 Dec 2025 10:12:06 -0700 Subject: [PATCH 1/2] remove dead code and deprecate option --- src/db.ts | 1 - src/operations/rename.ts | 7 ++++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/db.ts b/src/db.ts index 54724ae31be..0907b6f0a01 100644 --- a/src/db.ts +++ b/src/db.ts @@ -394,7 +394,6 @@ export class Db { toCollection, resolveOptions(undefined, { ...options, - new_collection: true, readPreference: ReadPreference.primary }) ) as TODO_NODE_3286 diff --git a/src/operations/rename.ts b/src/operations/rename.ts index 8969d27cde0..38f954df89d 100644 --- a/src/operations/rename.ts +++ b/src/operations/rename.ts @@ -11,7 +11,12 @@ import { Aspect, defineAspects } from './operation'; export interface RenameOptions extends Omit { /** Drop the target name collection if it previously exists. */ dropTarget?: boolean; - /** Unclear */ + /** + * @deprecated + * + * This option has been dead code since at least Node driver version 4.x. It will + * be removed in a future major release. + */ new_collection?: boolean; } From b6d10e83f6b39945e5636e6581e8b7c1a07b899f Mon Sep 17 00:00:00 2001 From: Bailey Pearson Date: Mon, 1 Dec 2025 12:32:36 -0700 Subject: [PATCH 2/2] Apply suggestion from @baileympearson --- src/operations/rename.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/operations/rename.ts b/src/operations/rename.ts index 38f954df89d..9def9852706 100644 --- a/src/operations/rename.ts +++ b/src/operations/rename.ts @@ -14,7 +14,7 @@ export interface RenameOptions extends Omit /** * @deprecated * - * This option has been dead code since at least Node driver version 4.x. It will + * This option has been dead code since at least Node driver version 4.x. It will * be removed in a future major release. */ new_collection?: boolean;