MONGOID-5164 Use None criteria instead of $in with empty list in HABTM association (#5467)

* MONGOID-5164 see if test fails when executing a query

* MONGOID-5164 fix tests

* omit apply_scope

Author: neilshweky

lib/mongoid/association/referenced/has_and_belongs_to_many.rb

@@ -263,8 +263,12 @@ def with_ordering(criteria)
 
         def query_criteria(id_list)
           crit = relation_class.criteria
-          crit = crit.apply_scope(scope)
-          crit = crit.all_of(primary_key => {"$in" => id_list || []})
+          crit = if id_list
+            crit = crit.apply_scope(scope)
+            crit.all_of(primary_key => { "$in" => id_list })
+          else
+            crit.none
+          end
           with_ordering(crit)
         end
       end

spec/mongoid/association/referenced/has_and_belongs_to_many/buildable_spec.rb

@@ -111,7 +111,7 @@
         end
 
         let(:criteria) do
-          Preference.all_of("_id" => { "$in" => [] })
+          Preference.none
         end
 
         it "a criteria object" do