DB User Translation Layer & SDK migration (#1543)

* PoC dbuser translation layer

* Move translation layer to a package

Signed-off-by: jose.vazquez <jose.vazquez@mongodb.com>

* Migrate translation later to new SDK

* Make translation function names consistent

* Fix e2e tests

Signed-off-by: jose.vazquez <jose.vazquez@mongodb.com>

* Convert To/FromAtlas

* Do not send password unless set

* Fix clusterwide int test

Signed-off-by: jose.vazquez <jose.vazquez@mongodb.com>

* Clean e2e tests

* Fix typo in action

Signed-off-by: jose.vazquez <jose.vazquez@mongodb.com>

* Fix empty value pointers to be nil

* Fix the dateFromAtlas translation

Signed-off-by: jose.vazquez <jose.vazquez@mongodb.com>

* Mark user tests to debug better

* Fix performUpdateInAtlas

* Add ListClusterDeploymentNames

* Fix comparison normalization

Signed-off-by: jose.vazquez <jose.vazquez@mongodb.com>

* Add TODO comment

* Interface renames & refactors

* Use translation and pointer

Signed-off-by: jose.vazquez <jose.vazquez@mongodb.com>

* Rename to ServerURL

* Use diffs instead

* Correct comparison logic with diffs

Signed-off-by: jose.vazquez <jose.vazquez@mongodb.com>

* Test clusterwide with local int tests

Signed-off-by: jose.vazquez <jose.vazquez@mongodb.com>

* Fix normalization

Signed-off-by: jose.vazquez <jose.vazquez@mongodb.com>

* Use common normalization code

* Specifically run int tests AND wide int tests

* Link TODO to follow up ticket CLOUDP-253951

* Avoid explicit enum normalizations already enforced by kube

* Fix error returns and cleanup unneeded code

* Add deletion unit tests

Signed-off-by: jose.vazquez <jose.vazquez@mongodb.com>

* Cover databaseuser changes with unit tests

* Added NewUser and DiffSpecs unit tests

* Add dbuser tests

Signed-off-by: jose.vazquez <jose.vazquez@mongodb.com>

* Fix and simplify diff into equals

Signed-off-by: jose.vazquez <jose.vazquez@mongodb.com>

* Clear refs from spec before comparison

* Clear debugging traces

---------

Signed-off-by: jose.vazquez <jose.vazquez@mongodb.com>

Author: josvazg

.licenses-gomod.sha256

@@ -1 +1 @@
-100644 00dda197f010caa332e89410c3ffee1369343795 go.mod
+100644 c73f2c61e23f551b04db496892f2d197c1325d38 go.mod

.mockery.yaml

@@ -7,3 +7,5 @@ mockname: "{{.InterfaceName}}Mock"
 all: true
 packages:
   github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/translation/ipaccesslist:
+  github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/translation/dbuser:
+  github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/translation/deployment:

go.mod

@@ -21,6 +21,7 @@ require (
 	github.com/google/go-cmp v0.6.0
 	github.com/google/uuid v1.6.0
 	github.com/mongodb-forks/digest v1.1.0
+	github.com/nsf/jsondiff v0.0.0-20230430225905-43f6cf3098c1
 	github.com/onsi/ginkgo/v2 v2.19.0
 	github.com/onsi/gomega v1.33.1
 	github.com/sethvargo/go-password v0.3.1

go.sum

@@ -203,6 +203,8 @@ github.com/montanaflynn/stats v0.7.1 h1:etflOAAHORrCC44V+aR6Ftzort912ZU+YLiSTuV8
 github.com/montanaflynn/stats v0.7.1/go.mod h1:etXPPgVO6n31NxCd9KQUMvCM+ve0ruNzt6R8Bnaayow=
 github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 h1:C3w9PqII01/Oq1c1nUAm88MOHcQC9l5mIlSMApZMrHA=
 github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822/go.mod h1:+n7T8mK8HuQTcFwEeznm/DIxMOiR9yIdICNftLE1DvQ=
+github.com/nsf/jsondiff v0.0.0-20230430225905-43f6cf3098c1 h1:dOYG7LS/WK00RWZc8XGgcUTlTxpp3mKhdR2Q9z9HbXM=
+github.com/nsf/jsondiff v0.0.0-20230430225905-43f6cf3098c1/go.mod h1:mpRZBD8SJ55OIICQ3iWH0Yz3cjzA61JdqMLoWXeB2+8=
 github.com/onsi/ginkgo/v2 v2.19.0 h1:9Cnnf7UHo57Hy3k6/m5k3dRfGTMXGvxhHFvkDTCTpvA=
 github.com/onsi/ginkgo/v2 v2.19.0/go.mod h1:rlwLi9PilAFJ8jCg9UE1QP6VBpd6/xj3SRC0d6TU0To=
 github.com/onsi/gomega v1.33.1 h1:dsYjIxxSR755MDmKVsaFQTE22ChNBcuuTWgkUDSubOk=

internal/cmp/normalize.go

@@ -29,7 +29,7 @@ func NormalizeSlice[S ~[]E, E any](slice S, cmp func(a, b E) int) S {
 	if len(slice) == 0 {
 		return nil
 	}
-	slices.SortFunc(slice, cmp)
+	slices.SortStableFunc(slice, cmp)
 	return slice
 }
 

internal/cmp/sort.go

@@ -49,3 +49,15 @@ func marshalJSON[T any](obj T) (string, error) {
 	}
 	return string(jObj), nil
 }
+
+func JSON[T any](obj T) []byte {
+	jObj, err := json.MarshalIndent(obj, "  ", "  ")
+	if err != nil {
+		return ([]byte)(err.Error())
+	}
+	return jObj
+}
+
+func JSONize[T any](obj T) string {
+	return string(JSON(obj))
+}