CLOUDP-161565: Remove autoIndexingEnabled flag from AutoScaling (#874)

* deprecate autoIndexingEnabled flag from AutoScaling spec of legacy deployment

Author: helderjs

config/crd/bases/atlas.mongodb.com_atlasdeployments.yaml

@@ -256,8 +256,9 @@ spec:
                       object.
                     properties:
                       autoIndexingEnabled:
-                        description: Flag that indicates whether autopilot mode for
-                          Performance Advisor is enabled. The default is false.
+                        description: 'Deprecated: This flag is not supported anymore.
+                          Flag that indicates whether autopilot mode for Performance
+                          Advisor is enabled. The default is false.'
                         type: boolean
                       compute:
                         description: Collection of settings that configure how a deployment
@@ -424,8 +425,9 @@ spec:
                           can scale.
                         properties:
                           autoIndexingEnabled:
-                            description: Flag that indicates whether autopilot mode
-                              for Performance Advisor is enabled. The default is false.
+                            description: 'Deprecated: This flag is not supported anymore.
+                              Flag that indicates whether autopilot mode for Performance
+                              Advisor is enabled. The default is false.'
                             type: boolean
                           compute:
                             description: Collection of settings that configure how
@@ -653,8 +655,9 @@ spec:
                           can scale.
                         properties:
                           autoIndexingEnabled:
-                            description: Flag that indicates whether autopilot mode
-                              for Performance Advisor is enabled. The default is false.
+                            description: 'Deprecated: This flag is not supported anymore.
+                              Flag that indicates whether autopilot mode for Performance
+                              Advisor is enabled. The default is false.'
                             type: boolean
                           compute:
                             description: Collection of settings that configure how

pkg/api/v1/atlasdeployment_types.go

@@ -255,6 +255,7 @@ type Specs struct {
 
 // AutoScalingSpec configures your deployment to automatically scale its storage
 type AutoScalingSpec struct {
+	// Deprecated: This flag is not supported anymore.
 	// Flag that indicates whether autopilot mode for Performance Advisor is enabled.
 	// The default is false.
 	AutoIndexingEnabled *bool `json:"autoIndexingEnabled,omitempty"`
@@ -492,6 +493,15 @@ var _ = RegionsConfig(mongodbatlas.RegionsConfig{})
 func (spec *AtlasDeploymentSpec) Deployment() (*mongodbatlas.Cluster, error) {
 	result := &mongodbatlas.Cluster{}
 	err := compat.JSONCopy(result, *spec.DeploymentSpec)
+
+	if result.AutoScaling != nil {
+		result.AutoScaling.AutoIndexingEnabled = nil
+	}
+
+	if result.ProviderSettings != nil && result.ProviderSettings.AutoScaling != nil {
+		result.ProviderSettings.AutoScaling.AutoIndexingEnabled = nil
+	}
+
 	return result, err
 }
 
@@ -670,8 +680,7 @@ func (c *AtlasDeployment) WithDiskSizeGB(size int) *AtlasDeployment {
 func (c *AtlasDeployment) WithAutoscalingDisabled() *AtlasDeployment {
 	f := false
 	c.Spec.DeploymentSpec.AutoScaling = &AutoScalingSpec{
-		AutoIndexingEnabled: &f,
-		DiskGBEnabled:       &f,
+		DiskGBEnabled: &f,
 		Compute: &ComputeSpec{
 			Enabled:          &f,
 			ScaleDownEnabled: &f,

pkg/controller/atlasdeployment/deployment.go

@@ -130,6 +130,14 @@ func cleanupDeployment(deployment mongodbatlas.Cluster) mongodbatlas.Cluster {
 		deployment.DiskSizeGB = nil
 	}
 
+	if deployment.AutoScaling != nil {
+		deployment.AutoScaling.AutoIndexingEnabled = nil
+	}
+
+	if deployment.ProviderSettings != nil && deployment.ProviderSettings.AutoScaling != nil {
+		deployment.ProviderSettings.AutoScaling.AutoIndexingEnabled = nil
+	}
+
 	return deployment
 }
 
@@ -158,10 +166,13 @@ func removeOutdatedFields(removeFrom *mongodbatlas.Cluster, lookAt *mongodbatlas
 				result.ProviderSettings.AutoScaling = &mongodbatlas.AutoScaling{}
 			}
 			result.ProviderSettings.AutoScaling.Compute = &mongodbatlas.Compute{}
+			result.ProviderSettings.AutoScaling.AutoIndexingEnabled = nil
 		}
 	}
 
 	if lookAt.AutoScaling != nil {
+		result.AutoScaling.AutoIndexingEnabled = nil
+
 		if lookAt.AutoScaling.DiskGBEnabled != nil && *lookAt.AutoScaling.DiskGBEnabled {
 			result.DiskSizeGB = nil
 		}

test/int/deployment_test.go

@@ -541,8 +541,7 @@ var _ = Describe("AtlasDeployment", Label("int", "AtlasDeployment"), func() {
 			createdDeployment = mdbv1.DefaultAWSDeployment(namespace.Name, createdProject.Name)
 			createdDeployment.Spec.DeploymentSpec.DiskSizeGB = intptr(20)
 			createdDeployment.Spec.DeploymentSpec.AutoScaling = &mdbv1.AutoScalingSpec{
-				AutoIndexingEnabled: boolptr(true),
-				DiskGBEnabled:       boolptr(true),
+				DiskGBEnabled: boolptr(true),
 			}
 
 			By(fmt.Sprintf("Creating the Deployment %s with autoscaling", kube.ObjectKeyFromObject(createdDeployment)), func() {