Merge pull request #752 from estolfo/RUBY-1089-upserted-count

RUBY-1089 Fix aggregated counts reported by Bulk Update operation

Author: estolfo

lib/mongo/bulk_write/result.rb

@@ -166,7 +166,7 @@ def upserted_count
       #
       # @since 2.1.0
       def upserted_ids
-        @results[UPSERTED_IDS]
+        @results[UPSERTED_IDS] || []
       end
 
       # Validates the bulk write result.

lib/mongo/bulk_write/result_combiner.rb

@@ -77,8 +77,8 @@ def result
 
       def combine_counts!(result)
         Result::FIELDS.each do |field|
-          if result.respond_to?(field)
-            results.merge!(field => (results[field] || 0) + result.send(field))
+          if result.respond_to?(field) && value = result.send(field)
+            results.merge!(field => (results[field] || 0) + value)
           end
         end
       end

lib/mongo/operation/write/bulk/delete/result.rb

@@ -34,7 +34,11 @@ module Aggregatable
             def n_removed
               return 0 unless acknowledged?
               @replies.reduce(0) do |n, reply|
-                n += reply.documents.first[Result::N]
+                if reply.documents.first[Result::N]
+                  n += reply.documents.first[Result::N]
+                else
+                  n
+                end
               end
             end
           end

lib/mongo/operation/write/bulk/update/result.rb

@@ -46,9 +46,9 @@ def n_upserted
               return 0 unless acknowledged?
               @replies.reduce(0) do |n, reply|
                 if upsert?(reply)
-                  n += 1
+                  n += reply.documents.first[UPSERTED].size
                 else
-                  n += 0
+                  n
                 end
               end
             end
@@ -65,14 +65,22 @@ def n_matched
               return 0 unless acknowledged?
               @replies.reduce(0) do |n, reply|
                 if upsert?(reply)
-                  n += 0
+                  reply.documents.first[N] - n_upserted
                 else
-                  n += reply.documents.first[N]
+                  if reply.documents.first[N]
+                    n += reply.documents.first[N]
+                  else
+                    n
+                  end
                 end
               end
             end
 
             # Gets the number of documents modified.
+            # Not that in a mixed sharded cluster a call to
+            # update could return nModified (>= 2.6) or not (<= 2.4).
+            # If any call does not return nModified we can't report
+            # a valid final count so set the field to nil.
             #
             # @example Get the modified count.
             #   result.n_modified
@@ -83,7 +91,11 @@ def n_matched
             def n_modified
               return 0 unless acknowledged?
               @replies.reduce(0) do |n, reply|
-                n += reply.documents.first[MODIFIED] || 0
+                if n && reply.documents.first[MODIFIED]
+                  n += reply.documents.first[MODIFIED]
+                else
+                  nil
+                end
               end
             end
 
@@ -155,12 +167,31 @@ def n_matched
                 end
               end
             end
-            alias :n_modified :n_matched
+
+            # Gets the number of documents modified.
+            #
+            # @example Get the modified count.
+            #   result.n_modified
+            #
+            # @return [ Integer ] The number of documents modified.
+            #
+            # @since 2.2.3
+            def n_modified
+              return 0 unless acknowledged?
+              @replies.reduce(0) do |n, reply|
+                if upsert?(reply)
+                  n
+                else
+                  updated_existing?(reply) ? n += reply.documents.first[N] : n
+                end
+              end
+            end
 
             private
 
             def upsert?(reply)
-              !updated_existing?(reply) && reply.documents.first[N] == 1
+              reply.documents.first[BulkWrite::Result::UPSERTED] ||
+                (!updated_existing?(reply) && reply.documents.first[N] == 1)
             end
 
             def updated_existing?(reply)