Simplify spec/mongo/socket/ssl_spec.rb

Author: niels

spec/mongo/socket/ssl_spec.rb

@@ -1,24 +1,23 @@
 require 'spec_helper'
 
-describe Mongo::Socket::SSL do
+describe Mongo::Socket::SSL, if: running_ssl? do
 
-  describe '#connect!', if: running_ssl? do
-
-    let(:socket) do
-      described_class.new(*DEFAULT_ADDRESS.split(":"), DEFAULT_ADDRESS.split(":")[0], 5, Socket::PF_INET, options)
-    end
+  let(:socket) do
+    described_class.new(*DEFAULT_ADDRESS.split(":"), DEFAULT_ADDRESS.split(":")[0], 5, Socket::PF_INET, options)
+  end
 
-    context 'when a certificate is provided' do
+  let(:options) do
+    {
+      :ssl => true,
+      :ssl_cert => CLIENT_PEM,
+      :ssl_key => CLIENT_PEM,
+      :ssl_verify => false
+    }
+  end
 
-      let(:options) do
-        {
-            :ssl => true,
-            :ssl_cert => CLIENT_PEM,
-            :ssl_key => CLIENT_PEM,
-            :ssl_verify => false
-        }
-      end
+  describe '#connect!' do
 
+    context 'when a certificate is provided' do
 
       context 'when connecting the tcp socket is successful' do
 
@@ -55,12 +54,9 @@
     context 'when a bad certificate is provided' do
 
       let(:options) do
-        {
-            :ssl => true,
-            :ssl_cert => CLIENT_PEM,
-            :ssl_key => CRL_PEM,
-            :ssl_verify => false
-        }
+        super().merge({
+          :ssl_key => CRL_PEM
+        })
       end
 
       it 'raises an exception' do
@@ -73,13 +69,10 @@
     context 'when a CA certificate is provided', if: testing_ssl_locally? do
 
       let(:options) do
-        {
-            :ssl => true,
-            :ssl_cert => CLIENT_PEM,
-            :ssl_key => CLIENT_PEM,
-            :ssl_ca_cert => CA_PEM,
-            :ssl_verify => true
-        }
+        super().merge({
+          :ssl_ca_cert => CA_PEM,
+          :ssl_verify => true
+        })
       end
 
       before do
@@ -94,12 +87,9 @@
     context 'when a CA certificate is not provided', if: testing_ssl_locally? do
 
       let(:options) do
-        {
-            :ssl => true,
-            :ssl_cert => CLIENT_PEM,
-            :ssl_key => CLIENT_PEM,
-            :ssl_verify => true
-        }
+        super().merge({
+          :ssl_verify => true
+        })
       end
 
       before do
@@ -115,12 +105,9 @@
     context 'when ssl_verify is not specified', if: testing_ssl_locally? do
 
       let(:options) do
-        {
-            :ssl => true,
-            :ssl_cert => CLIENT_PEM,
-            :ssl_key => CLIENT_PEM,
-            :ssl_ca_cert => CA_PEM
-        }
+        super().merge({
+          :ssl_ca_cert => CA_PEM
+        }).tap { |options| options.delete(:ssl_verify) }
       end
 
       before do
@@ -135,13 +122,10 @@
     context 'when ssl_verify is true', if: testing_ssl_locally? do
 
       let(:options) do
-        {
-            :ssl => true,
-            :ssl_cert => CLIENT_PEM,
-            :ssl_key => CLIENT_PEM,
-            :ssl_ca_cert => CA_PEM,
-            :ssl_verify => true
-        }
+        super().merge({
+          :ssl_ca_cert => CA_PEM,
+          :ssl_verify => true
+        })
       end
 
       before do
@@ -156,13 +140,10 @@
     context 'when ssl_verify is false' do
 
       let(:options) do
-        {
-            :ssl => true,
-            :ssl_cert => CLIENT_PEM,
-            :ssl_key => CLIENT_PEM,
-            :ssl_ca_cert => 'invalid',
-            :ssl_verify => false
-        }
+        super().merge({
+          :ssl_ca_cert => 'invalid',
+          :ssl_verify => false
+        })
       end
 
       before do