Connection#send_message should return bytes sent

Author: banker

lib/mongo/connection.rb

@@ -376,7 +376,7 @@ def slave_ok?
     # @param [BSON::ByteBuffer] message a message to send to the database.
     # @param [String] log_message text version of +message+ for logging.
     #
-    # @return [True]
+    # @return [Integer] number of bytes sent
     def send_message(operation, message, log_message=nil)
       @logger.debug("  MONGODB #{log_message || message}") if @logger
       begin
@@ -812,12 +812,17 @@ def add_message_headers(operation, message)
 
     # Low-level method for sending a message on a socket.
     # Requires a packed message and an available socket,
+    #
+    # @return [Integer] number of bytes sent
     def send_message_on_socket(packed_message, socket)
       begin
+      total_bytes_sent = 0
       while packed_message.size > 0
         byte_sent = socket.send(packed_message, 0)
+        total_bytes_sent += byte_sent
         packed_message.slice!(0, byte_sent)
       end
+      total_bytes_sent
       rescue => ex
         close
         raise ConnectionFailure, "Operation failed with the following exception: #{ex}"

test/collection_test.rb

@@ -259,6 +259,11 @@ def test_safe_remove
     @test.drop
   end
 
+  def test_remove_return_value
+    assert_equal 50, @@test.remove({})
+    assert_equal 57, @@test.remove({"x" => 1})
+  end
+
   def test_count
     @@test.drop