Use different method name, in case method is cached in specs

Author: estolfo

spec/mongo/server_selector/nearest_spec.rb

@@ -85,10 +85,10 @@
     context 'tag sets provided' do
       let(:tag_sets) { [tag_set] }
       let(:matching_primary) do
-        server(:primary, :tags => server_tags, address: default_address)
+        make_server(:primary, :tags => server_tags, address: default_address)
       end
       let(:matching_secondary) do
-        server(:secondary, :tags => server_tags, address: default_address)
+        make_server(:secondary, :tags => server_tags, address: default_address)
       end
 
       context 'single candidate' do
@@ -173,8 +173,8 @@
     end
 
     context 'high latency servers' do
-      let(:far_primary) { server(:primary, :average_round_trip_time => 113, address: default_address) }
-      let(:far_secondary) { server(:secondary, :average_round_trip_time => 114, address: default_address) }
+      let(:far_primary) { make_server(:primary, :average_round_trip_time => 113, address: default_address) }
+      let(:far_secondary) { make_server(:secondary, :average_round_trip_time => 114, address: default_address) }
 
       context 'single candidate' do
 

spec/mongo/server_selector/primary_preferred_spec.rb

@@ -81,11 +81,11 @@
       let(:tag_sets) { [tag_set] }
 
       let(:matching_primary) do
-        server(:primary, :tags => server_tags, address: default_address )
+        make_server(:primary, :tags => server_tags, address: default_address )
       end
 
       let(:matching_secondary) do
-        server(:secondary, :tags => server_tags, address: default_address )
+        make_server(:secondary, :tags => server_tags, address: default_address )
       end
 
       context 'single candidate' do
@@ -171,8 +171,8 @@
     end
 
     context 'high latency servers' do
-      let(:far_primary) { server(:primary, :average_round_trip_time => 100, address: default_address) }
-      let(:far_secondary) { server(:secondary, :average_round_trip_time => 113, address: default_address) }
+      let(:far_primary) { make_server(:primary, :average_round_trip_time => 100, address: default_address) }
+      let(:far_secondary) { make_server(:secondary, :average_round_trip_time => 113, address: default_address) }
 
       context 'single candidate' do
 

spec/mongo/server_selector/primary_spec.rb

@@ -76,8 +76,8 @@
     end
 
     context 'high latency candidates' do
-      let(:far_primary) { server(:primary, :average_round_trip_time => 100, address: default_address) }
-      let(:far_secondary) { server(:secondary, :average_round_trip_time => 120, address: default_address) }
+      let(:far_primary) { make_server(:primary, :average_round_trip_time => 100, address: default_address) }
+      let(:far_secondary) { make_server(:secondary, :average_round_trip_time => 120, address: default_address) }
 
       context 'single candidate' do
 

spec/mongo/server_selector/secondary_preferred_spec.rb

@@ -87,11 +87,11 @@
       end
 
       let(:matching_primary) do
-        server(:primary, :tags => server_tags, address: default_address)
+        make_server(:primary, :tags => server_tags, address: default_address)
       end
 
       let(:matching_secondary) do
-        server(:secondary, :tags => server_tags, address: default_address)
+        make_server(:secondary, :tags => server_tags, address: default_address)
       end
 
       context 'single candidate' do
@@ -170,8 +170,8 @@
     end
 
     context 'high latency servers' do
-      let(:far_primary) { server(:primary, :average_round_trip_time => 100, address: default_address) }
-      let(:far_secondary) { server(:secondary, :average_round_trip_time => 113, address: default_address) }
+      let(:far_primary) { make_server(:primary, :average_round_trip_time => 100, address: default_address) }
+      let(:far_secondary) { make_server(:secondary, :average_round_trip_time => 113, address: default_address) }
 
       context 'single candidate' do
 

spec/mongo/server_selector/secondary_spec.rb

@@ -76,7 +76,7 @@
 
     context 'tag sets provided' do
       let(:tag_sets) { [tag_set] }
-      let(:matching_secondary) { server(:secondary, :tags => server_tags, address: default_address) }
+      let(:matching_secondary) { make_server(:secondary, :tags => server_tags, address: default_address) }
 
       context 'single candidate' do
 
@@ -134,8 +134,8 @@
     end
 
     context 'high latency servers' do
-      let(:far_primary) { server(:primary, :average_round_trip_time => 100, address: default_address) }
-      let(:far_secondary) { server(:secondary, :average_round_trip_time => 113, address: default_address) }
+      let(:far_primary) { make_server(:primary, :average_round_trip_time => 100, address: default_address) }
+      let(:far_secondary) { make_server(:secondary, :average_round_trip_time => 113, address: default_address) }
 
       context 'single candidate' do
 

spec/mongo/server_selector_spec.rb

@@ -145,7 +145,7 @@
     context 'when #select returns a list of nils' do
 
       let(:servers) do
-        [ server(:primary) ]
+        [ make_server(:primary) ]
       end
 
       let(:cluster) do
@@ -174,7 +174,7 @@
     context 'when the cluster has a server_selection_timeout set' do
 
       let(:servers) do
-        [ server(:secondary), server(:primary) ]
+        [ make_server(:secondary), make_server(:primary) ]
       end
 
       let(:cluster) do
@@ -201,14 +201,14 @@
     context 'when the cluster has a local_threshold set' do
 
       let(:near_server) do
-        server(:secondary).tap do |s|
+        make_server(:secondary).tap do |s|
           allow(s).to receive(:connectable?).and_return(true)
           allow(s).to receive(:average_round_trip_time).and_return(100)
         end
       end
 
       let(:far_server) do
-        server(:secondary).tap do |s|
+        make_server(:secondary).tap do |s|
           allow(s).to receive(:connectable?).and_return(true)
           allow(s).to receive(:average_round_trip_time).and_return(200)
         end

spec/support/shared/server_selector.rb

@@ -1,4 +1,4 @@
-def server(mode, options = {})
+def make_server(mode, options = {})
   tags = options[:tags] || {}
   average_round_trip_time = options[:average_round_trip_time] || 0
 
@@ -30,8 +30,8 @@ def server(mode, options = {})
   let(:server_tags) do
     { 'test' => 'tag', 'other' => 'tag' }
   end
-  let(:primary) { server(:primary) }
-  let(:secondary) { server(:secondary) }
+  let(:primary) { make_server(:primary) }
+  let(:secondary) { make_server(:secondary) }
   let(:options) { { :mode => name, :tag_sets => tag_sets } }
   let(:selector) { described_class.new(options) }