RUBY-1279 App name in app metadata should be string

Author: estolfo

lib/mongo/cluster/app_metadata.rb

@@ -52,7 +52,7 @@ class AppMetadata
       #
       # @since 2.4.0
       def initialize(cluster)
-        @app_name = cluster.options[:app_name]
+        @app_name = cluster.options[:app_name].to_s if cluster.options[:app_name]
         @platform = cluster.options[:platform]
         @compressors = cluster.options[:compressors] || []
       end

spec/mongo/client_spec.rb

@@ -1123,7 +1123,7 @@
       end
 
       let(:new_options) do
-        { app_name: 'reports' }
+        { app_name: 'client_test' }
       end
 
       let!(:new_client) do

spec/mongo/cluster/app_metadata_spec.rb

@@ -14,18 +14,34 @@
 
     context 'when the cluster has an app name option set' do
 
+      let(:client) do
+        authorized_client.with(app_name: :app_metadata_test)
+      end
+
       let(:cluster) do
-        authorized_client.with(app_name: :reports).cluster
+        client.cluster
+      end
+
+      after do
+        client.close
       end
 
       it 'sets the app name' do
-        expect(app_metadata.send(:full_client_document)[:application][:name]).to eq(:reports)
+        expect(app_metadata.send(:full_client_document)[:application][:name]).to eq('app_metadata_test')
       end
 
       context 'when the app name exceeds the max length of 128' do
 
+        let(:client) do
+          authorized_client.with(app_name: "\u3042"*43)
+        end
+
         let(:cluster) do
-          authorized_client.with(app_name: "\u3042"*43).cluster
+          client.cluster
+        end
+
+        after do
+          client.close
         end
 
         it 'raises an error' do

spec/mongo/cluster_spec.rb

@@ -491,11 +491,11 @@
     context 'when the client has an app_name set' do
 
       let(:cluster) do
-        authorized_client.with(app_name: 'reports').cluster
+        authorized_client.with(app_name: 'cluster_test').cluster
       end
 
       it 'constructs an AppMetadata object with the app_name' do
-        expect(cluster.app_metadata.send(:full_client_document)[:application]).to eq('name' => 'reports')
+        expect(cluster.app_metadata.send(:full_client_document)[:application]).to eq('name' => 'cluster_test')
       end
     end
 

spec/mongo/max_staleness_spec.rb

@@ -67,7 +67,9 @@
 
       let(:in_latency_window) do
         spec.in_latency_window.collect do |server|
-          Mongo::Server.new(Mongo::Address.new(server['address']), cluster, monitoring, listeners, options)
+          s = Mongo::Server.new(Mongo::Address.new(server['address']), cluster, monitoring, listeners, options)
+          s.monitor.stop!
+          s
         end
       end
 

spec/mongo/uri/srv_protocol_spec.rb

@@ -896,10 +896,10 @@
       end
 
       context 'when an app name option is provided' do
-        let(:options) { "appname=reports" }
+        let(:options) { "appname=srv_test" }
 
         it 'sets the app name on the client' do
-          expect(Mongo::Client.new(string).options[:app_name]).to eq(:reports)
+          expect(Mongo::Client.new(string).options[:app_name]).to eq(:srv_test)
         end
       end
 

spec/mongo/uri_spec.rb

@@ -962,10 +962,10 @@
     end
 
     context 'when an app name option is provided' do
-      let(:options) { "appname=reports" }
+      let(:options) { "appname=uri_test" }
 
       it 'sets the app name on the client' do
-        expect(Mongo::Client.new(string).options[:app_name]).to eq(:reports)
+        expect(Mongo::Client.new(string).options[:app_name]).to eq(:uri_test)
       end
     end