PHPLIB-798: Use more flexible assertions for connection counts (#894)

Author: jmikola

tests/SpecTests/PrimaryStepDownSpecTest.php

@@ -43,7 +43,7 @@ public function setUp(): void
     }
 
     /**
-     * @see https://github.com/mongodb/specifications/tree/master/source/connections-survive-step-down/tests#id10
+     * @see https://github.com/mongodb/specifications/tree/master/source/connections-survive-step-down/tests#not-primary-keep-connection-pool
      */
     public function testNotPrimaryKeepsConnectionPool(): void
     {
@@ -79,7 +79,7 @@ public function testNotPrimaryKeepsConnectionPool(): void
     }
 
     /**
-     * @see https://github.com/mongodb/specifications/tree/master/source/connections-survive-step-down/tests#id11
+     * @see https://github.com/mongodb/specifications/tree/master/source/connections-survive-step-down/tests#not-primary-reset-connection-pool
      */
     public function testNotPrimaryResetConnectionPool(): void
     {
@@ -106,16 +106,19 @@ public function testNotPrimaryResetConnectionPool(): void
             $this->assertSame(self::NOT_PRIMARY, $e->getCode());
         }
 
-        // Verify that the connection pool has been cleared
-        $this->assertSame($totalConnectionsCreated + 1, $this->getTotalConnectionsCreated());
+        /* Verify that the connection pool has been cleared and that a new
+         * connection has been created. Use ">=" to allow for the possibility
+         * that the server created additional connections unrelated to this
+         * test. */
+        $this->assertGreaterThanOrEqual($totalConnectionsCreated + 1, $this->getTotalConnectionsCreated());
 
         // Execute an insert into the test collection of a {test: 1} document and verify that it succeeds.
         $result = $this->insertDocuments(1);
         $this->assertSame(1, $result->getInsertedCount());
     }
 
     /**
-     * @see https://github.com/mongodb/specifications/tree/master/source/connections-survive-step-down/tests#id12
+     * @see https://github.com/mongodb/specifications/tree/master/source/connections-survive-step-down/tests#shutdown-in-progress-reset-connection-pool
      */
     public function testShutdownResetConnectionPool(): void
     {
@@ -142,16 +145,19 @@ public function testShutdownResetConnectionPool(): void
             $this->assertSame(self::SHUTDOWN_IN_PROGRESS, $e->getCode());
         }
 
-        // Verify that the connection pool has been cleared
-        $this->assertSame($totalConnectionsCreated + 1, $this->getTotalConnectionsCreated());
+        /* Verify that the connection pool has been cleared and that a new
+         * connection has been created. Use ">=" to allow for the possibility
+         * that the server created additional connections unrelated to this
+         * test. */
+        $this->assertGreaterThanOrEqual($totalConnectionsCreated + 1, $this->getTotalConnectionsCreated());
 
         // Execute an insert into the test collection of a {test: 1} document and verify that it succeeds.
         $result = $this->insertDocuments(1);
         $this->assertSame(1, $result->getInsertedCount());
     }
 
     /**
-     * @see https://github.com/mongodb/specifications/tree/master/source/connections-survive-step-down/tests#id13
+     * @see https://github.com/mongodb/specifications/tree/master/source/connections-survive-step-down/tests#interrupted-at-shutdown-reset-connection-pool
      */
     public function testInterruptedAtShutdownResetConnectionPool(): void
     {
@@ -178,16 +184,19 @@ public function testInterruptedAtShutdownResetConnectionPool(): void
             $this->assertSame(self::INTERRUPTED_AT_SHUTDOWN, $e->getCode());
         }
 
-        // Verify that the connection pool has been cleared
-        $this->assertSame($totalConnectionsCreated + 1, $this->getTotalConnectionsCreated());
+        /* Verify that the connection pool has been cleared and that a new
+         * connection has been created. Use ">=" to allow for the possibility
+         * that the server created additional connections unrelated to this
+         * test. */
+        $this->assertGreaterThanOrEqual($totalConnectionsCreated + 1, $this->getTotalConnectionsCreated());
 
         // Execute an insert into the test collection of a {test: 1} document and verify that it succeeds.
         $result = $this->insertDocuments(1);
         $this->assertSame(1, $result->getInsertedCount());
     }
 
     /**
-     * @see https://github.com/mongodb/specifications/tree/master/source/connections-survive-step-down/tests#id9
+     * @see https://github.com/mongodb/specifications/tree/master/source/connections-survive-step-down/tests#getmore-iteration
      */
     public function testGetMoreIteration(): void
     {