Use error message when error code is not specific to atlas search on old server versions

Author: GromNaN

phpunit.xml.dist

@@ -16,6 +16,7 @@
         <ini name="zend.assertions" value="1"/>
         <env name="MONGODB_URI" value="mongodb://127.0.0.1:27017/?serverSelectionTimeoutMS=100"/>
         <env name="MONGODB_DATABASE" value="phplib_test"/>
+        <env name="ATLAS_SUPPORTED" value="0" />
     </php>
 
     <testsuites>

src/Exception/AtlasSearchNotSupportedException.php

@@ -0,0 +1,42 @@
+<?php
+
+namespace MongoDB\Exception;
+
+use MongoDB\Driver\Exception\ServerException;
+use Throwable;
+
+use function in_array;
+
+final class AtlasSearchNotSupportedException extends ServerException
+{
+    /** @internal */
+    public static function create(ServerException $e): self
+    {
+        $message = $e->getCode() === 31082 ? $e->getMessage() : 'Using Atlas Search Database Commands and the $listSearchIndexes aggregation stage requires additional configuration. Please connect to Atlas or an AtlasCLI local deployment to enable. For more information on how to connect, see https://dochub.mongodb.org/core/atlas-cli-deploy-local-reqs';
+
+        return new self($message, $e->getCode(), $e);
+    }
+
+    /** @internal */
+    public static function isAtlasSearchNotSupportedError(Throwable $e): bool
+    {
+        if (! $e instanceof ServerException) {
+            return false;
+        }
+
+        return match($e->getCode()) {
+            // MongoDB 8: Using Atlas Search Database Commands and the $listSearchIndexes aggregation stage requires additional configuration.
+            31082 => true,
+            // MongoDB 7: $listSearchIndexes stage is only allowed on MongoDB Atlas
+            6047401 => true,
+            // MongoDB 7-ent: Search index commands are only supported with Atlas.
+            115 => true,
+            // MongoDB 4 to 6, 7-community
+            59 => str_contains('no such command: \'createSearchIndexes\'', $e->getMessage()),
+            // MongoDB 4 to 6
+            40324 => str_contains('Unrecognized pipeline stage name: \'$listSearchIndexes\'', $e->getMessage()),
+            // Not an Atlas Search error
+            default => false,
+        };
+    }
+}

src/Exception/SearchNotSupportedException.php

@@ -28,7 +28,7 @@
 use MongoDB\Driver\Session;
 use MongoDB\Driver\WriteConcern;
 use MongoDB\Exception\InvalidArgumentException;
-use MongoDB\Exception\SearchNotSupportedException;
+use MongoDB\Exception\AtlasSearchNotSupportedException;
 use MongoDB\Exception\UnexpectedValueException;
 use MongoDB\Exception\UnsupportedException;
 use MongoDB\Model\CodecCursor;
@@ -238,8 +238,8 @@ public function execute(Server $server): CursorInterface
         try {
             $cursor = $this->executeCommand($server, $command);
         } catch (ServerException $exception) {
-            if (SearchNotSupportedException::isSearchNotSupportedError($exception)) {
-                throw SearchNotSupportedException::create($exception);
+            if (AtlasSearchNotSupportedException::isAtlasSearchNotSupportedError($exception)) {
+                throw AtlasSearchNotSupportedException::create($exception);
             }
 
             throw $exception;

src/Operation/Aggregate.php

@@ -22,7 +22,7 @@
 use MongoDB\Driver\Exception\ServerException;
 use MongoDB\Driver\Server;
 use MongoDB\Exception\InvalidArgumentException;
-use MongoDB\Exception\SearchNotSupportedException;
+use MongoDB\Exception\AtlasSearchNotSupportedException;
 use MongoDB\Exception\UnsupportedException;
 use MongoDB\Model\SearchIndexInput;
 
@@ -88,8 +88,8 @@ public function execute(Server $server): array
         try {
             $cursor = $server->executeCommand($this->databaseName, new Command($cmd));
         } catch (ServerException $exception) {
-            if (SearchNotSupportedException::isSearchNotSupportedError($exception)) {
-                throw SearchNotSupportedException::create($exception);
+            if (AtlasSearchNotSupportedException::isAtlasSearchNotSupportedError($exception)) {
+                throw AtlasSearchNotSupportedException::create($exception);
             }
 
             throw $exception;

src/Operation/CreateSearchIndexes.php

@@ -13,7 +13,7 @@
 use MongoDB\Driver\ReadPreference;
 use MongoDB\Driver\WriteConcern;
 use MongoDB\Exception\InvalidArgumentException;
-use MongoDB\Exception\SearchNotSupportedException;
+use MongoDB\Exception\AtlasSearchNotSupportedException;
 use MongoDB\Exception\UnsupportedException;
 use MongoDB\Operation\Count;
 use MongoDB\Tests\CommandObserver;
@@ -808,32 +808,6 @@ public function testListSearchIndexesInheritTypeMap(): void
         $this->assertIsArray($indexes[0]);
     }
 
-    public function testListSearchIndexesNotSupportedException(): void
-    {
-        if (self::isAtlas()) {
-            self::markTestSkipped('Atlas Search is supported on Atlas');
-        }
-
-        $collection = new Collection($this->manager, $this->getDatabaseName(), $this->getCollectionName());
-
-        $this->expectException(SearchNotSupportedException::class);
-
-        $collection->listSearchIndexes();
-    }
-
-    public function testCreateSearchIndexNotSupportedException(): void
-    {
-        if (self::isAtlas()) {
-            self::markTestSkipped('Atlas Search is supported on Atlas');
-        }
-
-        $collection = new Collection($this->manager, $this->getDatabaseName(), $this->getCollectionName());
-
-        $this->expectException(SearchNotSupportedException::class);
-
-        $collection->createSearchIndex(['mappings' => ['dynamic' => false]], ['name' => 'test-search-index']);
-    }
-
     /**
      * Create data fixtures.
      */

tests/Collection/CollectionFunctionalTest.php

@@ -230,8 +230,7 @@ public static function provideExamples(): Generator
     #[Group('atlas')]
     public function testAtlasSearch(): void
     {
-        $uri = getenv('MONGODB_URI') ?? '';
-        if (! self::isAtlas($uri)) {
+        if (! self::isAtlas()) {
             $this->markTestSkipped('Atlas Search examples are only supported on MongoDB Atlas');
         }
 

tests/ExamplesTest.php

@@ -0,0 +1,62 @@
+<?php
+
+namespace Exception;
+
+use MongoDB\Collection;
+use MongoDB\Driver\Command;
+use MongoDB\Driver\Exception\ServerException;
+use MongoDB\Exception\AtlasSearchNotSupportedException;
+use MongoDB\Tests\Collection\FunctionalTestCase;
+
+class AtlasSearchNotSupportedExceptionTest extends FunctionalTestCase
+{
+    public function testListSearchIndexesNotSupportedException(): void
+    {
+        if (self::isAtlas()) {
+            self::markTestSkipped('Atlas Search is supported on Atlas');
+        }
+
+        $collection = new Collection($this->manager, $this->getDatabaseName(), $this->getCollectionName());
+
+        $this->expectException(AtlasSearchNotSupportedException::class);
+
+        $collection->listSearchIndexes();
+    }
+
+    public function testCreateSearchIndexNotSupportedException(): void
+    {
+        if (self::isAtlas()) {
+            self::markTestSkipped('Atlas Search is supported on Atlas');
+        }
+
+        $collection = new Collection($this->manager, $this->getDatabaseName(), $this->getCollectionName());
+
+        $this->expectException(AtlasSearchNotSupportedException::class);
+
+        $collection->createSearchIndex(['mappings' => ['dynamic' => false]], ['name' => 'test-search-index']);
+    }
+
+    public function testOtherStageNotFound(): void
+    {
+        $collection = new Collection($this->manager, $this->getDatabaseName(), $this->getCollectionName());
+
+        try {
+            $collection->aggregate([
+                ['$searchStageNotExisting' => ['text' => ['query' => 'test', 'path' => 'field']]],
+            ]);
+            self::fail('Expected ServerException was not thrown');
+        } catch (ServerException $exception) {
+            self::assertNotInstanceOf(AtlasSearchNotSupportedException::class, $exception, $exception);
+        }
+    }
+
+    public function testOtherCommandNotFound(): void
+    {
+        try {
+            $this->manager->executeCommand($this->getDatabaseName(), new Command(['nonExistingCommand' => 1]));
+            self::fail('Expected ServerException was not thrown');
+        } catch (ServerException $exception) {
+            self::assertFalse(AtlasSearchNotSupportedException::isAtlasSearchNotSupportedError($exception));
+        }
+    }
+}

tests/Exception/AtlasSearchNotSupportedExceptionTest.php

@@ -50,8 +50,6 @@
 
 abstract class FunctionalTestCase extends TestCase
 {
-    private const ATLAS_TLD = '/\.(mongodb\.net|mongodb-dev\.net)/';
-
     protected Manager $manager;
 
     private array $configuredFailPoints = [];
@@ -520,7 +518,7 @@ protected function isEnterprise(): bool
 
     public static function isAtlas(?string $uri = null): bool
     {
-        return preg_match(self::ATLAS_TLD, $uri ?? static::getUri());
+        return (bool) getenv('ATLAS_SUPPORTED');
     }
 
     /** @see https://www.mongodb.com/docs/manual/core/queryable-encryption/reference/shared-library/ */