Implemented new prose test for Transactions #1824
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| /* | ||
| * Copyright 2008-present MongoDB, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.mongodb.reactivestreams.client; | ||
|
|
||
| import com.mongodb.ConnectionString; | ||
| import com.mongodb.MongoClientSettings; | ||
| import com.mongodb.WriteConcern; | ||
| import org.bson.Document; | ||
| import org.junit.jupiter.api.AfterEach; | ||
| import org.junit.jupiter.api.Assertions; | ||
| import org.junit.jupiter.api.BeforeEach; | ||
| import org.junit.jupiter.api.DisplayName; | ||
| import org.junit.jupiter.api.Test; | ||
| import reactor.core.publisher.Mono; | ||
| import reactor.test.StepVerifier; | ||
|
|
||
| import static com.mongodb.ClusterFixture.getConnectionString; | ||
| import static com.mongodb.ClusterFixture.getDefaultDatabaseName; | ||
| import static com.mongodb.ClusterFixture.getMultiMongosConnectionString; | ||
| import static com.mongodb.ClusterFixture.isSharded; | ||
| import static com.mongodb.ClusterFixture.isStandalone; | ||
| import static com.mongodb.ClusterFixture.serverVersionAtLeast; | ||
| import static org.junit.jupiter.api.Assumptions.abort; | ||
| import static org.junit.jupiter.api.Assumptions.assumeTrue; | ||
|
|
||
| public class TransactionProseTest { | ||
| private MongoClient client; | ||
| private MongoCollection<Document> collection; | ||
|
|
||
| @BeforeEach | ||
| public void setUp() { | ||
| assumeTrue(!isStandalone()); | ||
| ConnectionString connectionString = getConnectionString(); | ||
| if (isSharded()) { | ||
| assumeTrue(serverVersionAtLeast(4, 2)); | ||
| connectionString = getMultiMongosConnectionString(); | ||
| assumeTrue(connectionString != null); | ||
| } | ||
|
|
||
| client = MongoClients.create(MongoClientSettings.builder() | ||
| .applyConnectionString(connectionString) | ||
| .build()); | ||
|
|
||
| collection = client.getDatabase(getDefaultDatabaseName()).getCollection(getClass().getName()); | ||
| StepVerifier.create(Mono.from(collection.drop())).verifyComplete(); | ||
| } | ||
|
|
||
| @AfterEach | ||
| public void tearDown() { | ||
| if (collection != null) { | ||
| StepVerifier.create(Mono.from(collection.drop())).verifyComplete(); | ||
| } | ||
| if (client != null) { | ||
| client.close(); | ||
| } | ||
| } | ||
|
|
||
| @DisplayName("Mongos Pinning Prose Tests: 1. Test that starting a new transaction on a pinned ClientSession unpins the session " | ||
| + "and normal server selection is performed for the next operation.") | ||
| @Test | ||
| void testNewTransactionUnpinsSession() { | ||
| abort("There is no ability to get the server address with the reactive api"); | ||
|
Contributor
There was a problem hiding this comment. Why can't we call ? client.getClusterDescription().getServerDescriptions()
Member
Author
There was a problem hiding this comment. The tests require the actual cursor server address - which isn't available in the reactive streams implementation |
||
| } | ||
|
|
||
| @DisplayName("Mongos Pinning Prose Tests: 2. Test non-transaction operations using a pinned ClientSession unpins the session" | ||
| + " and normal server selection is performed") | ||
| @Test | ||
| void testNonTransactionOpsUnpinsSession() { | ||
| abort("There is no ability to get the server address with the reactive api"); | ||
| } | ||
|
|
||
| @DisplayName("Options Inside Transaction Prose Tests. 1. Write concern not inherited from collection object inside transaction") | ||
| @Test | ||
| void testWriteConcernInheritance() { | ||
|
Member
Author
There was a problem hiding this comment. Having to use map / flatMap to pass the session into each Mono is painful. But appears to be the correct way to ensure that the session use is correctly ordered. |
||
| // Create a MongoClient running against a configured sharded/replica set/load balanced cluster. | ||
| // transactions require a 4.0+ server when non-sharded and 4.2+ when sharded | ||
| if (isSharded()) { | ||
| assumeTrue(serverVersionAtLeast(4, 2)); | ||
| } else { | ||
| assumeTrue(serverVersionAtLeast(4, 0)); | ||
| } | ||
|
|
||
| Mono.from(collection.insertOne(Document.parse("{}"))).block(); | ||
|
|
||
| Mono<Document> testWriteConcern = Mono.from(client.startSession()) | ||
| .flatMap(session -> | ||
| Mono.fromRunnable(session::startTransaction) | ||
| .then(Mono.from(collection.withWriteConcern(WriteConcern.UNACKNOWLEDGED).insertOne(session, new Document("n", 1)))) | ||
| .then(Mono.from(session.commitTransaction())) | ||
| .then(Mono.from(collection.find(new Document("n", 1)).first())) | ||
| .doFinally(signalType -> session.close()) | ||
| ); | ||
|
|
||
| StepVerifier.create(testWriteConcern).assertNext(Assertions::assertNotNull).verifyComplete(); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Writing the reactive streams prose test identified a bug. Validation was done when the publisher was created and not when the publisher was being used.
This complicated the usage of transactions, a fact that was hidden by the lack of prose tests! This fix is in the remit of JAVA-5895