Implemented new prose test for Transactions #1824

rozza · 2025-10-14T09:38:36Z

Ensuring collection write concern options are ignored when inside a transaction.

…ons are ignored when inside a transaction. JAVA-5684

rozza · 2025-10-14T09:41:24Z

...ive-streams/src/test/functional/com/mongodb/reactivestreams/client/TransactionProseTest.java

+
+    @DisplayName("Options Inside Transaction Prose Tests. 1. Write concern not inherited from collection object inside transaction")
+    @Test
+    void testWriteConcernInheritance() {


Having to use map / flatMap to pass the session into each Mono is painful. But appears to be the correct way to ensure that the session use is correctly ordered.

rozza · 2025-10-14T09:41:44Z

driver-sync/src/test/functional/com/mongodb/client/TransactionProseTest.java

 import static com.mongodb.ClusterFixture.isSharded;
-import static org.junit.Assert.assertTrue;
-import static org.junit.Assume.assumeTrue;
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;


I took the opportunity to modernize the test to junit5

rozza · 2025-10-14T09:43:10Z

driver-sync/src/test/functional/com/mongodb/client/TransactionProseTest.java

                session.startTransaction();
-                addresses.add(collection.find(session, Document.parse("{}")));
+                try (MongoCursor<Document> cursor = collection.find(session, Document.parse("{}")).cursor()) {
+                    addresses.add(cursor.getServerAddress());


The test wasn't to spec as it didn't actually check the server addresses, as it does in the prose test spec.

rozza · 2025-10-14T09:44:24Z

driver-sync/src/test/functional/com/mongodb/client/TransactionProseTest.java

-            session = client.startSession();
+    public void testNewTransactionUnpinsSession() {
+        collection.insertOne(Document.parse("{}"));
+        try (ClientSession session = client.startSession()) {


Prefer try with resources (this code was from java 6 days).

rozza · 2025-10-14T09:44:52Z

driver-sync/src/test/functional/com/mongodb/client/TransactionProseTest.java

-        return isSharded();
+    @DisplayName("Options Inside Transaction Prose Tests. 1. Write concern not inherited from collection object inside transaction")
+    @Test
+    void testWriteConcernInheritance() {


The new prose test.

…on cold publishers Only run the validation when subscribe has been called. JAVA-5985

rozza · 2025-10-14T10:54:49Z

...streams/src/main/com/mongodb/reactivestreams/client/internal/ClientSessionPublisherImpl.java

    }

    @Override
    public Publisher<Void> commitTransaction() {


Writing the reactive streams prose test identified a bug. Validation was done when the publisher was created and not when the publisher was being used.

This complicated the usage of transactions, a fact that was hidden by the lack of prose tests! This fix is in the remit of JAVA-5895

...ive-streams/src/test/functional/com/mongodb/reactivestreams/client/TransactionProseTest.java

nhachicha · 2025-11-10T15:05:12Z

...ive-streams/src/test/functional/com/mongodb/reactivestreams/client/TransactionProseTest.java

+                .applyConnectionString(multiMongosConnectionString);
+
+        client = MongoClients.create(MongoClientSettings.builder(builder.build())
+                .applyToSocketSettings(builder1 -> builder1.readTimeout(5, TimeUnit.SECONDS))


Why do we need the SocketSettings?

Not 100% sure it was in the original sync prose tests

Removed it and will see if it causes any issues

nhachicha · 2025-11-10T15:23:21Z

driver-sync/src/test/functional/com/mongodb/client/TransactionProseTest.java

-            collection.insertOne(Document.parse("{}"));
-            session = client.startSession();
+    public void testNewTransactionUnpinsSession() {
+        collection.insertOne(Document.parse("{}"));


we can add assumeTrue(serverVersionAtLeast(4, 2)); // spec requires 4.1.6

nhachicha · 2025-11-10T15:37:09Z

driver-sync/src/test/functional/com/mongodb/client/TransactionProseTest.java

-        try {
-            collection.insertOne(Document.parse("{}"));
-            session = client.startSession();
+         collection.insertOne(Document.parse("{}"));


ditto (version check)

nhachicha · 2025-11-10T15:38:56Z

driver-sync/src/test/functional/com/mongodb/client/TransactionProseTest.java

+        try (ClientSession session = client.startSession()) {
            session.startTransaction();
            collection.insertOne(session, Document.parse("{ _id : 1 }"));
+            session.commitTransaction();


The spec test doesn't commit the transaction, an oversight? (same for the previous test)

I think thats just the pythonic code - it uses a with block that auto closes / commits the transaction.

nhachicha · 2025-11-10T15:47:05Z

driver-sync/src/test/functional/com/mongodb/client/TransactionProseTest.java

+    @DisplayName("Options Inside Transaction Prose Tests. 1. Write concern not inherited from collection object inside transaction")
+    @Test
+    void testWriteConcernInheritance() {
+        assumeTrue(serverVersionAtLeast(4, 4));


Why 4.4 only? Isn't this supposed to run against

transactions require a 4.0+ server when non-sharded and 4.2+ when sharded

It was 4.4+ but have updated all the version checking

driver-sync/src/test/functional/com/mongodb/client/TransactionProseTest.java

nhachicha · 2025-11-10T15:55:43Z

driver-sync/src/test/functional/com/mongodb/client/TransactionProseTest.java

+        try (ClientSession session = client.startSession()) {
+            MongoCollection<Document> wcCollection = collection.withWriteConcern(new WriteConcern(0));
+
+            assertDoesNotThrow(() -> {


I'm not sure at which point this test asserts that the write concern is not inherited ?

Yeah its quite implicit, if it inherited the UNACKNOWLEDGED write concern it would throw an error. - This just checks for the absence of an error and therefore the lack of inheritance.

nhachicha · 2025-11-10T16:14:28Z

...ive-streams/src/test/functional/com/mongodb/reactivestreams/client/TransactionProseTest.java

+            + "and normal server selection is performed for the next operation.")
+    @Test
+    void testNewTransactionUnpinsSession() {
+        abort("There is no ability to get the server address with the reactive api");


Why can't we call ?

client.getClusterDescription().getServerDescriptions()

The tests require the actual cursor server address - which isn't available in the reactive streams implementation

…vestreams/client/TransactionProseTest.java Co-authored-by: Nabil Hachicha <nabil.hachicha@gmail.com>

…ProseTest.java Co-authored-by: Nabil Hachicha <nabil.hachicha@gmail.com>

rozza · 2025-11-11T13:53:18Z

Updated - waiting to see if the new version checks (sharded & non sharded) cause any issues in CI.

Implemented new prose test for ensuring collection write concern opti…

66eb45b

…ons are ignored when inside a transaction. JAVA-5684

rozza requested a review from a team as a code owner October 14, 2025 09:38

rozza requested review from Copilot, katcharov and nhachicha and removed request for a team and katcharov October 14, 2025 09:38

This comment was marked as outdated.

Sign in to view

rozza commented Oct 14, 2025

View reviewed changes

PR update - ensure session always cleaned up

bb815e8

rozza requested a review from Copilot October 14, 2025 09:52

This comment was marked as outdated.

Sign in to view

rozza added 4 commits October 14, 2025 10:54

Remove comment as the display name explains the test

eb277f9

Simplify the reactive streams logic

b6715db

Actually assert

2b03fbc

Make ClientSession#commitTransaction and ClientSession#abortTransacti…

b1f5e10

…on cold publishers Only run the validation when subscribe has been called. JAVA-5985

rozza commented Oct 14, 2025

View reviewed changes

Fix prose test requirements

91528ec

nhachicha reviewed Nov 10, 2025

View reviewed changes

rozza and others added 3 commits November 11, 2025 13:17

Update driver-reactive-streams/src/test/functional/com/mongodb/reacti…

e59ae45

…vestreams/client/TransactionProseTest.java Co-authored-by: Nabil Hachicha <nabil.hachicha@gmail.com>

Update driver-sync/src/test/functional/com/mongodb/client/Transaction…

757ed2f

…ProseTest.java Co-authored-by: Nabil Hachicha <nabil.hachicha@gmail.com>

PR review updates

643396d

rozza added 3 commits November 11, 2025 14:56

Create collection in prose test before transaction

a51574c

Standalone servers don't support retryable writes

a98ae75

Ensure not standalone

3cadb2b

Implemented new prose test for Transactions #1824

Are you sure you want to change the base?

Implemented new prose test for Transactions #1824

Uh oh!

Conversation

rozza commented Oct 14, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rozza commented Nov 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants