minor: fix clippy (#267)

Author: isabelatkinson

src/bson.rs

@@ -118,7 +118,7 @@ impl Display for Bson {
             }) => write!(fmt, "/{}/{}", pattern, options),
             Bson::JavaScriptCode(ref code)
             | Bson::JavaScriptCodeWithScope(JavaScriptCodeWithScope { ref code, .. }) => {
-                fmt.write_str(&code)
+                fmt.write_str(code)
             }
             Bson::Int32(i) => write!(fmt, "{}", i),
             Bson::Int64(i) => write!(fmt, "{}", i),

src/de/serde.rs

@@ -326,7 +326,7 @@ impl<'de> de::Deserializer<'de> for Deserializer {
             Bson::Binary(Binary {
                 subtype: BinarySubtype::Generic,
                 ref bytes,
-            }) => visitor.visit_bytes(&bytes),
+            }) => visitor.visit_bytes(bytes),
             binary @ Bson::Binary(..) => visitor.visit_map(MapDeserializer {
                 iter: binary.to_extended_document().into_iter(),
                 value: None,

src/extjson/de.rs

@@ -200,7 +200,7 @@ impl TryFrom<serde_json::Value> for Bson {
                 .or_else(|| x.as_f64().map(Bson::from))
                 .ok_or_else(|| {
                     Error::invalid_value(
-                        Unexpected::Other(&format!("{}", x).as_str()),
+                        Unexpected::Other(format!("{}", x).as_str()),
                         &"a number that could fit in i32, i64, or f64",
                     )
                 }),

src/ser/mod.rs

@@ -108,8 +108,8 @@ pub(crate) fn serialize_bson<W: Write + ?Sized>(
 
     match *val {
         Bson::Double(v) => write_f64(writer, v),
-        Bson::String(ref v) => write_string(writer, &v),
-        Bson::Array(ref v) => serialize_array(writer, &v),
+        Bson::String(ref v) => write_string(writer, v),
+        Bson::Array(ref v) => serialize_array(writer, v),
         Bson::Document(ref v) => v.to_writer(writer),
         Bson::Boolean(v) => writer
             .write_all(&[if v { 0x01 } else { 0x00 }])
@@ -121,7 +121,7 @@ pub(crate) fn serialize_bson<W: Write + ?Sized>(
             write_cstring(writer, pattern)?;
             write_cstring(writer, options)
         }
-        Bson::JavaScriptCode(ref code) => write_string(writer, &code),
+        Bson::JavaScriptCode(ref code) => write_string(writer, code),
         Bson::ObjectId(ref id) => writer.write_all(&id.bytes()).map_err(From::from),
         Bson::JavaScriptCodeWithScope(JavaScriptCodeWithScope {
             ref code,
@@ -155,7 +155,7 @@ pub(crate) fn serialize_bson<W: Write + ?Sized>(
         }
         Bson::DateTime(ref v) => write_i64(writer, v.timestamp_millis()),
         Bson::Null => Ok(()),
-        Bson::Symbol(ref v) => write_string(writer, &v),
+        Bson::Symbol(ref v) => write_string(writer, v),
         #[cfg(not(feature = "decimal128"))]
         Bson::Decimal128(ref v) => {
             writer.write_all(&v.bytes)?;

src/tests/modules/document.rs

@@ -105,8 +105,8 @@ fn test_getters() {
 
     doc.insert("null".to_string(), Bson::Null);
     assert_eq!(Some(&Bson::Null), doc.get("null"));
-    assert_eq!(true, doc.is_null("null"));
-    assert_eq!(false, doc.is_null("array"));
+    assert!(doc.is_null("null"));
+    assert!(!doc.is_null("array"));
 
     assert_eq!(Some(&Bson::Int32(1)), doc.get("i32"));
     assert_eq!(Ok(1i32), doc.get_i32("i32"));

src/tests/modules/ser.rs

@@ -50,7 +50,7 @@ fn boolean() {
     let _guard = LOCK.run_concurrently();
     let obj = Bson::Boolean(true);
     let b: bool = from_bson(obj.clone()).unwrap();
-    assert_eq!(b, true);
+    assert!(b);
 
     let deser: Bson = to_bson(&b).unwrap();
     assert_eq!(deser, obj);

src/tests/serde.rs

@@ -760,7 +760,7 @@ fn test_datetime_helpers() {
                 }
         }
     }"#;
-        let json: serde_json::Value = serde_json::from_str(&date).unwrap();
+        let json: serde_json::Value = serde_json::from_str(date).unwrap();
         let b: B = serde_json::from_value(json).unwrap();
         let expected: chrono::DateTime<chrono::Utc> =
             chrono::DateTime::from_str("2020-06-09 10:58:07.095 UTC").unwrap();