Skip to content

Conversation

@nirinchev
Copy link
Collaborator

Proposed changes

This will make it easier for library consumers (i.e. vscode) to construct a valid user config with all defaults.

@nirinchev nirinchev requested a review from a team as a code owner December 1, 2025 12:42
Copilot AI review requested due to automatic review settings December 1, 2025 12:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR exports the UserConfigSchema from the library's public API to enable external consumers (such as the VSCode extension) to programmatically construct valid user configurations with proper defaults and validation.

Key Changes:

  • Export UserConfigSchema alongside the existing UserConfig type from the library's entry point

@coveralls
Copy link
Collaborator

coveralls commented Dec 1, 2025

Pull Request Test Coverage Report for Build 19827900409

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 80.468%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 19766295633: -0.004%
Covered Lines: 6669
Relevant Lines: 8205

💛 - Coveralls

@himanshusinghs
Copy link
Collaborator

Just to mention - #767 covers this so if its not urgent shall we wait for that to land. Happy to have this merged as well.

@nirinchev nirinchev merged commit 0e7d241 into main Dec 1, 2025
18 checks passed
@nirinchev nirinchev deleted the ni/userconfig-schema branch December 1, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants