Simplify Compiler::add_library_constant (combine lib and member)

Author: khvzak

src/chunk.rs

@@ -349,16 +349,19 @@ impl Compiler {
     /// The constants are used by the compiler to optimize the generated bytecode.
     /// Optimization level must be at least 2 for this to have any effect.
     ///
-    /// The first element of the tuple is the library name,the second is the member name, and the
-    /// third is the constant value.
+    /// The `name` is a string in the format `lib.member`, where `lib` is the library name
+    /// and `member` is the member (constant) name.
     #[must_use]
     pub fn add_library_constant(
         mut self,
-        lib: impl Into<StdString>,
-        member: impl Into<StdString>,
+        name: impl AsRef<str>,
         r#const: impl Into<CompileConstant>,
     ) -> Self {
-        let (lib, member) = (lib.into(), member.into());
+        let Some((lib, member)) = name.as_ref().split_once('.') else {
+            return self;
+        };
+        let (lib, member) = (lib.to_owned(), member.to_owned());
+
         if !self.libraries_with_known_members.contains(&lib) {
             self.libraries_with_known_members.push(lib.clone());
         }

tests/chunk.rs

@@ -145,10 +145,10 @@ fn test_compiler_library_constants() {
 
     let compiler = Compiler::new()
         .set_optimization_level(2)
-        .add_library_constant("mylib", "const_bool", true)
-        .add_library_constant("mylib", "const_num", 123.0)
-        .add_library_constant("mylib", "const_vec", Vector::zero())
-        .add_library_constant("mylib", "const_str", "value1");
+        .add_library_constant("mylib.const_bool", true)
+        .add_library_constant("mylib.const_num", 123.0)
+        .add_library_constant("mylib.const_vec", Vector::zero())
+        .add_library_constant("mylib.const_str", "value1");
 
     let lua = Lua::new();
     lua.set_compiler(compiler);