From 37e3ff640078d91a68c1213ad033ac4e914df3f6 Mon Sep 17 00:00:00 2001 From: Maximiliano Osorio Date: Mon, 31 Aug 2026 21:25:59 -0400 Subject: [PATCH] chore(ui-react): keep the BRANDING comment with the key it explains The prose sat above the conditional, so an unbranded deployment shipped six lines of comment about a key its ConfigMap does not contain. The other optional keys put their prose outside the conditional, but they are emitted almost always: EXECUTION_ENGINE and DATA_CATALOG_API both fall back to a derived value. BRANDING defaults to empty, so absent is its common case. No key changes. Left for the next release rather than a version of its own. --- charts/mint/templates/ui-react-config.yaml | 8 ++++---- charts/mint/values.yaml | 1 + 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/charts/mint/templates/ui-react-config.yaml b/charts/mint/templates/ui-react-config.yaml index 7fc2bc4..2045da5 100644 --- a/charts/mint/templates/ui-react-config.yaml +++ b/charts/mint/templates/ui-react-config.yaml @@ -65,13 +65,13 @@ data: AUTH_CALLBACK_ORIGIN: {{ . | quote }} {{- end }} + {{- with $cfg.branding }} # Presentation. Which co-branding chrome the application renders -- the # branding strip, the footer and the dark header. It names a preset held in # the image, so the logo files, link targets and alt text stay under code - # review rather than living in these values. Left empty, the image's own - # default applies, which is unbranded. Set it only on a deployment entitled - # to show that institution's marks. - {{- with $cfg.branding }} + # review rather than living in these values. Set only on a deployment + # entitled to show that institution's marks; left empty the key is omitted + # and the image's own default applies, which is unbranded. BRANDING: {{ . | quote }} {{- end }} diff --git a/charts/mint/values.yaml b/charts/mint/values.yaml index fa57dcd..a744335 100644 --- a/charts/mint/values.yaml +++ b/charts/mint/values.yaml @@ -452,6 +452,7 @@ components: # -- Origin to use for the OAuth2 callback. Leave empty to use the # deployment's own origin, which is correct for a real cluster host. auth_callback_origin: "" + # Presentation. # -- Co-branding chrome the React UI renders: the branding strip, the # footer and the dark header. `tacc` shows the TACC and UT Austin marks; # `none` shows no institutional chrome. Names a preset held in the image,