🔖 ✨ v1.1.1 - added total tax reconstruction rule for better coverage

Author: jonathanMindee

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Mindee python SDK
 
+## v1.1.1 (2020-01-31)
+
+### Chg
+
+* Updated total tax reconstruction for invoice
+
 ## v1.1.0 (2020-12-02)
 
 ### Chg

mindee/documents/invoice.py

@@ -188,9 +188,10 @@ def _reconstruct(self):
         """
         Call fields reconstruction methods
         """
-        self.__reconstruct_total_tax()
+        self.__reconstruct_total_tax_from_tax_lines()
         self.__reconstruct_total_excl_from_tcc_and_taxes()
         self.__reconstruct_total_incl_from_taxes_plus_excl()
+        self.__reconstruct_total_tax_from_incl_and_excl()
 
     def _checklist(self):
         """
@@ -337,7 +338,7 @@ def __reconstruct_total_excl_from_tcc_and_taxes(self):
             }
             self.total_excl = Amount(total_excl, value_key="value", reconstructed=True)
 
-    def __reconstruct_total_tax(self):
+    def __reconstruct_total_tax_from_tax_lines(self):
         """
         Set self.total_tax with Amount object
         The total_tax Amount value is the sum of all self.taxes value
@@ -351,6 +352,25 @@ def __reconstruct_total_tax(self):
             if total_tax["value"] > 0:
                 self.total_tax = Amount(total_tax, value_key="value", reconstructed=True)
 
+    def __reconstruct_total_tax_from_incl_and_excl(self):
+        """
+        Set self.total_tax with Amount object
+        Check if the total tax was already set
+        If not, set thta total tax amount to the diff of incl and excl
+        """
+        if self.total_tax.value is not None or\
+                self.total_excl.value is None or\
+                self.total_incl.value is None:
+                pass
+        else:
+
+            total_tax = {
+                "value": self.total_incl.value - self.total_excl.value,
+                "probability": self.total_incl.probability * self.total_excl.probability
+            }
+            if total_tax["value"] >= 0:
+                self.total_tax = Amount(total_tax, value_key="value", reconstructed=True)
+
     @staticmethod
     def compute_accuracy(invoice, ground_truth):
         """