Skip to content

Commit e1f610d

Browse files
committed
optimize request collecton creation
1 parent 37ceeae commit e1f610d

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

src/msgraph_core/requests/batch_request_content_collection.py

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ def __init__(self) -> None:
1616
1717
1818
"""
19+
self.max_requests_per_batch = BatchRequestContent.MAX_REQUESTS
1920
self.batches: List[BatchRequestContent] = []
2021
self.current_batch: BatchRequestContent = BatchRequestContent()
2122

@@ -25,14 +26,10 @@ def add_batch_request_item(self, request: BatchRequestItem) -> None:
2526
Args:
2627
request (BatchRequestItem): The request item to add.
2728
"""
28-
try:
29-
self.current_batch.add_request(request)
30-
except ValueError as e:
31-
if "Maximum number of requests is" in str(e):
32-
self.batches.append(self.current_batch.finalize())
33-
34-
self.current_batch = BatchRequestContent()
35-
self.current_batch.add_request(request)
29+
if len(self.current_batch.requests) >= self.max_requests_per_batch:
30+
self.batches.append(self.current_batch.finalize())
31+
self.current_batch = BatchRequestContent()
32+
self.current_batch.add_request(request)
3633
self.batches.append(self.current_batch)
3734

3835
def remove_batch_request_item(self, request_id: str) -> None:

0 commit comments

Comments
 (0)