From 676d9410013b286bf5b5568d27f7ff525f054254 Mon Sep 17 00:00:00 2001 From: Kaleb Luedtke Date: Sat, 18 Apr 2026 13:16:07 -0500 Subject: [PATCH 1/3] Add policy for notifying authors of Localization Restriction --- .../policies/labelManagement.issueOpened.yml | 30 +++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/.github/policies/labelManagement.issueOpened.yml b/.github/policies/labelManagement.issueOpened.yml index f24d06f8ed..036d1d8932 100644 --- a/.github/policies/labelManagement.issueOpened.yml +++ b/.github/policies/labelManagement.issueOpened.yml @@ -15,6 +15,36 @@ configuration: action: Opened then: - addCodeFlowLink + - description: Check for modifications of Localization files in new PRs + if: + - payloadType: Pull_Request + - isAction: + action: Opened + - filesMatchPattern: + pattern: Localization/Resources/* + - not: + activitySenderHasPermission: # Only trigger if the sender doesn't have write permissions, + permission: write # to avoid adding the label for PRs from MSFT intentionally updating these files + then: + - addLabel: + label: Needs-Author-Feedback + - addLabel: + label: Blocking-Issue + - addReply: + reply: >- + Hello ${issueAuthor}, + + + Thank you for your contribution! It looks like your PR includes changes to localization files. + + + The English resource file [**/en-us/winget.resw](https://github.com/microsoft/winget-cli/blob/master/src/AppInstallerCLIPackage/Shared/Strings/en-us/winget.resw) is the only file contributors should edit for string changes. It feeds the Microsoft localization pipeline. The files under [Localization\Resources\\](https://github.com/microsoft/winget-cli/tree/master/Localization/Resources) are **automatically synced from Microsoft's internal localization system and must not be edited**. Any manual edits will be overwritten on the next sync. + + + Instead of this PR, it would be helpful if you could [open an issue](https://github.com/microsoft/winget-cli/issues/new?template=Documentation_Issue.yml) so the internal localization team can review it. For more information, please see the [Development Guide](https://github.com/microsoft/winget-cli/blob/master/doc/Developing.md#localization). + + + Template: msftbot/PullRequests/LocalizationFileChange - description: Add Needs-Triage to new issues if: - payloadType: Issues From 2c126a3a66261761e0bf0d1a3cdd925949b5808e Mon Sep 17 00:00:00 2001 From: Kaleb Luedtke Date: Sat, 18 Apr 2026 17:17:50 -0500 Subject: [PATCH 2/3] Capitalize permission Co-authored-by: Muhammad Danish --- .github/policies/labelManagement.issueOpened.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/policies/labelManagement.issueOpened.yml b/.github/policies/labelManagement.issueOpened.yml index 036d1d8932..0fab04942a 100644 --- a/.github/policies/labelManagement.issueOpened.yml +++ b/.github/policies/labelManagement.issueOpened.yml @@ -24,7 +24,7 @@ configuration: pattern: Localization/Resources/* - not: activitySenderHasPermission: # Only trigger if the sender doesn't have write permissions, - permission: write # to avoid adding the label for PRs from MSFT intentionally updating these files + permission: Write # to avoid adding the label for PRs from MSFT intentionally updating these files then: - addLabel: label: Needs-Author-Feedback From 08e496516896361ec5fa28df32ffea92e31ceebf Mon Sep 17 00:00:00 2001 From: Kaleb Luedtke Date: Mon, 20 Apr 2026 13:08:30 -0500 Subject: [PATCH 3/3] New Issue template --- .github/ISSUE_TEMPLATE/Localization_Issue.yml | 13 +++++++++++++ .github/policies/labelManagement.issueOpened.yml | 2 +- 2 files changed, 14 insertions(+), 1 deletion(-) create mode 100644 .github/ISSUE_TEMPLATE/Localization_Issue.yml diff --git a/.github/ISSUE_TEMPLATE/Localization_Issue.yml b/.github/ISSUE_TEMPLATE/Localization_Issue.yml new file mode 100644 index 0000000000..fac0185ecf --- /dev/null +++ b/.github/ISSUE_TEMPLATE/Localization_Issue.yml @@ -0,0 +1,13 @@ +name: '🌐 Localization Issue' +description: Report issues in our localization. +type: Task +labels: +- Issue-Localization +- Needs-Triage +body: + - type: textarea + attributes: + label: Brief description of your issue + placeholder: Briefly describe which localization needs to be corrected and why. + validations: + required: true diff --git a/.github/policies/labelManagement.issueOpened.yml b/.github/policies/labelManagement.issueOpened.yml index 0fab04942a..96e6fa1d07 100644 --- a/.github/policies/labelManagement.issueOpened.yml +++ b/.github/policies/labelManagement.issueOpened.yml @@ -41,7 +41,7 @@ configuration: The English resource file [**/en-us/winget.resw](https://github.com/microsoft/winget-cli/blob/master/src/AppInstallerCLIPackage/Shared/Strings/en-us/winget.resw) is the only file contributors should edit for string changes. It feeds the Microsoft localization pipeline. The files under [Localization\Resources\\](https://github.com/microsoft/winget-cli/tree/master/Localization/Resources) are **automatically synced from Microsoft's internal localization system and must not be edited**. Any manual edits will be overwritten on the next sync. - Instead of this PR, it would be helpful if you could [open an issue](https://github.com/microsoft/winget-cli/issues/new?template=Documentation_Issue.yml) so the internal localization team can review it. For more information, please see the [Development Guide](https://github.com/microsoft/winget-cli/blob/master/doc/Developing.md#localization). + Instead of this PR, it would be helpful if you could [open an issue](https://github.com/microsoft/winget-cli/issues/new?template=Localization_Issue.yml) and it will be forwarded to the internal localization team for review. For more information, please see the [Development Guide](https://github.com/microsoft/winget-cli/blob/master/doc/Developing.md#localization). Template: msftbot/PullRequests/LocalizationFileChange