Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Commit 9e88c35

Browse files
committed
update wording, fix using v2 by default
1 parent c1b1eb0 commit 9e88c35

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

src/node/extension/configurationProvider.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -482,7 +482,6 @@ function getWithoutDefault<T>(setting: string): T | undefined {
482482
return info?.workspaceValue ?? info?.globalValue;
483483
}
484484

485-
486485
function nvsStandardArchName(arch) {
487486
switch (arch) {
488487
case '32':
@@ -530,14 +529,18 @@ async function annoyingDeprecationNotification() {
530529

531530
const useNewDebugger = 'Upgrade';
532531
hasShownDeprecation = true;
533-
const result = await vscode.window.showWarningMessage("You're using an old Node.js debugger which will be deprecated soon. Please upgrade to our new debugger, and file issues if you run into any problems", useNewDebugger);
532+
const inspect = vscode.workspace.getConfiguration().inspect(v3Setting);
533+
const isWorkspace = inspect?.workspaceValue === false;
534+
const result = await vscode.window.showWarningMessage(
535+
`You're using a ${isWorkspace ? 'workspace' : 'user'} setting to use VS Code's legacy Node.js debugger, which will be removed soon. Please update your settings using the "Upgrade" button to use our modern debugger.`,
536+
useNewDebugger,
537+
);
534538

535539
if (result !== useNewDebugger) {
536540
return;
537541
}
538542

539543
const config = vscode.workspace.getConfiguration();
540-
const inspect = config.inspect(v3Setting);
541544
if (inspect?.globalValue === false) {
542545
config.update(v3Setting, true, vscode.ConfigurationTarget.Global);
543546
}

0 commit comments

Comments
 (0)