fix: Only show migration Quick fixes for opened tasks.json (#674)

Author: CsCherrYY

src/tasks/migration/DiagnosticProvider.ts

@@ -6,7 +6,6 @@ import * as fs from "fs";
 import * as path from "path";
 import * as readline from "readline";
 import * as vscode from "vscode";
-import { getTasksJsonPaths } from "./utils";
 import { DeprecatedExportJarTaskProvider, ExportJarTaskProvider } from "../../exportJarSteps/ExportJarTaskProvider";
 
 export class DiagnosticProvider implements vscode.Disposable {
@@ -21,12 +20,21 @@ export class DiagnosticProvider implements vscode.Disposable {
         this.refreshDiagnosticsTrigger = _.debounce(this.refreshDiagnostics, 500 /** ms */);
         this.diagnosticCollection = vscode.languages.createDiagnosticCollection("migrateExportTask");
         this.disposables.push(this.diagnosticCollection);
-        this.disposables.push(vscode.workspace.onDidChangeTextDocument(async (e) => {
+        this.disposables.push(vscode.workspace.onDidChangeTextDocument(async (e: vscode.TextDocumentChangeEvent) => {
             if (path.basename(e.document.fileName) === "tasks.json") {
                 this.refreshDiagnosticsTrigger(e.document.uri);
             }
         }));
-        this.initializeDiagnostics();
+        this.disposables.push(vscode.workspace.onDidOpenTextDocument(async (e: vscode.TextDocument) => {
+            if (path.basename(e.fileName) === "tasks.json") {
+                this.refreshDiagnosticsTrigger(e.uri);
+            }
+        }));
+        this.disposables.push(vscode.workspace.onDidCloseTextDocument(async (e: vscode.TextDocument) => {
+            if (path.basename(e.fileName) === "tasks.json") {
+                this.diagnosticCollection.set(e.uri, undefined);
+            }
+        }));
     }
 
     public dispose() {
@@ -35,14 +43,6 @@ export class DiagnosticProvider implements vscode.Disposable {
         }
     }
 
-    private async initializeDiagnostics(): Promise<void> {
-        const tasksJsonPaths = await getTasksJsonPaths();
-        for (const tasksJsonPath of tasksJsonPaths) {
-            const diagnostics: vscode.Diagnostic[] = await DiagnosticProvider.getDiagnosticsFromTasksJsonPath(tasksJsonPath);
-            this.diagnosticCollection.set(vscode.Uri.file(tasksJsonPath), diagnostics);
-        }
-    }
-
     private async refreshDiagnostics(uri: vscode.Uri): Promise<void> {
         const diagnostics: vscode.Diagnostic[] = await DiagnosticProvider.getDiagnosticsFromTasksJsonPath(uri.fsPath);
         this.diagnosticCollection.set(uri, diagnostics);

src/tasks/migration/utils.ts

@@ -1,27 +1,12 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT license.
 
-import * as fse from "fs-extra";
-import * as path from "path";
 import { Range, tasks, TextDocument, workspace, WorkspaceEdit } from "vscode";
 import { DeprecatedExportJarTaskProvider } from "../../exportJarSteps/ExportJarTaskProvider";
 import { contextManager } from "../../contextManager";
 import { Context } from "../../constants";
 import { CodeActionProvider } from "./CodeActionProvider";
 
-export async function getTasksJsonPaths(): Promise<string[]> {
-    const tasksJsonPaths = [];
-    if (workspace.workspaceFolders?.length) {
-        for (const folder of workspace.workspaceFolders) {
-            const tasksJsonPath = path.join(folder.uri.fsPath, ".vscode", "tasks.json");
-            if (await fse.pathExists(tasksJsonPath)) {
-                tasksJsonPaths.push(tasksJsonPath);
-            }
-        }
-    }
-    return tasksJsonPaths;
-}
-
 export async function updateExportTaskType(document: TextDocument, range: Range): Promise<void> {
     const workspaceEdit = new WorkspaceEdit();
     workspaceEdit.replace(document.uri, range, CodeActionProvider.JAVA_BUILD_ARTIFACT_TYPE);