From 263b466386f36b8b4df5737bec18bcdf51277008 Mon Sep 17 00:00:00 2001 From: Jake Bailey <5341706+jakebailey@users.noreply.github.com> Date: Tue, 17 Feb 2026 19:50:18 -0800 Subject: [PATCH] Remove redundant JSDoc flag checks --- internal/ast/utilities.go | 6 ++---- internal/astnav/tokens.go | 12 +++++------- internal/checker/checker.go | 12 +++++------- internal/ls/selectionranges.go | 6 ++---- 4 files changed, 14 insertions(+), 22 deletions(-) diff --git a/internal/ast/utilities.go b/internal/ast/utilities.go index 7a8dcecd3c..ed05b6f6c1 100644 --- a/internal/ast/utilities.go +++ b/internal/ast/utilities.go @@ -2942,10 +2942,8 @@ func IsParameterPropertyModifier(kind Kind) bool { } func ForEachChildAndJSDoc(node *Node, sourceFile *SourceFile, v Visitor) bool { - if node.Flags&NodeFlagsHasJSDoc != 0 { - if visitNodes(v, node.JSDoc(sourceFile)) { - return true - } + if visitNodes(v, node.JSDoc(sourceFile)) { + return true } return node.ForEachChild(v) } diff --git a/internal/astnav/tokens.go b/internal/astnav/tokens.go index a0d231dd52..172da6dd4b 100644 --- a/internal/astnav/tokens.go +++ b/internal/astnav/tokens.go @@ -282,13 +282,11 @@ func VisitEachChildAndJSDoc( visitNodes func(*ast.NodeList, *ast.NodeVisitor) *ast.NodeList, ) { visitor := getNodeVisitor(visitNode, visitNodes) - if node.Flags&ast.NodeFlagsHasJSDoc != 0 { - for _, jsdoc := range node.JSDoc(sourceFile) { - if visitor.Hooks.VisitNode != nil { - visitor.Hooks.VisitNode(jsdoc, visitor) - } else { - visitor.VisitNode(jsdoc) - } + for _, jsdoc := range node.JSDoc(sourceFile) { + if visitor.Hooks.VisitNode != nil { + visitor.Hooks.VisitNode(jsdoc, visitor) + } else { + visitor.VisitNode(jsdoc) } } node.VisitEachChild(visitor) diff --git a/internal/checker/checker.go b/internal/checker/checker.go index 76924c9009..5cb96a08f5 100644 --- a/internal/checker/checker.go +++ b/internal/checker/checker.go @@ -2173,13 +2173,11 @@ func (c *Checker) checkSourceElement(node *ast.Node) bool { } func (c *Checker) checkSourceElementWorker(node *ast.Node) { - if node.Flags&ast.NodeFlagsHasJSDoc != 0 { - for _, jsdoc := range node.EagerJSDoc(nil) { - c.checkJSDocComments(jsdoc) - if tags := jsdoc.AsJSDoc().Tags; tags != nil { - for _, tag := range tags.Nodes { - c.checkJSDocComments(tag) - } + for _, jsdoc := range node.EagerJSDoc(nil) { + c.checkJSDocComments(jsdoc) + if tags := jsdoc.AsJSDoc().Tags; tags != nil { + for _, tag := range tags.Nodes { + c.checkJSDocComments(tag) } } } diff --git a/internal/ls/selectionranges.go b/internal/ls/selectionranges.go index 8bc5ba534a..6180ab4615 100644 --- a/internal/ls/selectionranges.go +++ b/internal/ls/selectionranges.go @@ -196,10 +196,8 @@ func getSmartSelectionRange(l *LanguageService, sourceFile *ast.SourceFile, pos } // Visit JSDoc nodes first if they exist - if current.Flags&ast.NodeFlagsHasJSDoc != 0 { - for _, jsdoc := range current.JSDoc(sourceFile) { - visit(jsdoc) - } + for _, jsdoc := range current.JSDoc(sourceFile) { + visit(jsdoc) } tempVisitor := ast.NewNodeVisitor(visit, nil, ast.NodeVisitorHooks{