From 13d6de08e4e8f0c9cef9383677747e8530e222ae Mon Sep 17 00:00:00 2001 From: Qiming Bao Date: Sat, 7 Nov 2026 05:24:58 +0000 Subject: [PATCH] Python: Fix presence_penalty, frequency_penalty and n ranges in MistralAIChatPromptExecutionSettings presence_penalty and frequency_penalty used Field(gt=0), which rejected 0 (no penalty) and every negative value, and n used Field(gt=1), which rejected n=1. Converting generic settings that carry presence_penalty=0 or frequency_penalty=0 through from_prompt_execution_settings therefore failed with a ValidationError. The Mistral API spec (ChatCompletionRequest) defines both penalties as numbers in [-2, 2] and n as an integer >= 1. The mistralai SDK does not validate these fields, so mirror the API: ge=-2.0, le=2.0 for the penalties and ge=1 for n. --- .../mistral_ai_prompt_execution_settings.py | 6 +-- .../test_mistralai_request_settings.py | 40 +++++++++++++++++++ 2 files changed, 43 insertions(+), 3 deletions(-) diff --git a/python/semantic_kernel/connectors/ai/mistral_ai/prompt_execution_settings/mistral_ai_prompt_execution_settings.py b/python/semantic_kernel/connectors/ai/mistral_ai/prompt_execution_settings/mistral_ai_prompt_execution_settings.py index 6788b2c38191..3e18dd57c710 100644 --- a/python/semantic_kernel/connectors/ai/mistral_ai/prompt_execution_settings/mistral_ai_prompt_execution_settings.py +++ b/python/semantic_kernel/connectors/ai/mistral_ai/prompt_execution_settings/mistral_ai_prompt_execution_settings.py @@ -36,9 +36,9 @@ class MistralAIChatPromptExecutionSettings(MistralAIPromptExecutionSettings): temperature: Annotated[float | None, Field(ge=0.0, le=2.0)] = None top_p: Annotated[float | None, Field(ge=0.0, le=1.0)] = None random_seed: int | None = None - presence_penalty: Annotated[float | None, Field(gt=0)] = None - frequency_penalty: Annotated[float | None, Field(gt=0)] = None - n: Annotated[int | None, Field(gt=1)] = None + presence_penalty: Annotated[float | None, Field(ge=-2.0, le=2.0)] = None + frequency_penalty: Annotated[float | None, Field(ge=-2.0, le=2.0)] = None + n: Annotated[int | None, Field(ge=1)] = None retries: utils.RetryConfig | None = None server_url: str | None = None timeout_ms: int | None = None diff --git a/python/tests/unit/connectors/ai/mistral_ai/test_mistralai_request_settings.py b/python/tests/unit/connectors/ai/mistral_ai/test_mistralai_request_settings.py index 579d979884b7..58fac1946794 100644 --- a/python/tests/unit/connectors/ai/mistral_ai/test_mistralai_request_settings.py +++ b/python/tests/unit/connectors/ai/mistral_ai/test_mistralai_request_settings.py @@ -1,5 +1,8 @@ # Copyright (c) Microsoft. All rights reserved. +import pytest +from pydantic import ValidationError + from semantic_kernel.connectors.ai.mistral_ai.prompt_execution_settings.mistral_ai_prompt_execution_settings import ( MistralAIChatPromptExecutionSettings, ) @@ -138,3 +141,40 @@ def test_prepare_settings_dict_keeps_explicit_random_seed(): options = settings.prepare_settings_dict() assert "seed" not in options assert options["random_seed"] == 7 + + +@pytest.mark.parametrize("penalty_name", ["presence_penalty", "frequency_penalty"]) +@pytest.mark.parametrize("value", [-2.0, -0.5, 0.0, 0.5, 2.0]) +def test_penalties_accept_values_in_mistral_range(penalty_name: str, value: float): + # The Mistral API accepts presence_penalty and frequency_penalty in [-2, 2], 0 means no penalty. + settings = MistralAIChatPromptExecutionSettings(**{penalty_name: value}) + assert settings.prepare_settings_dict()[penalty_name] == value + + +@pytest.mark.parametrize("penalty_name", ["presence_penalty", "frequency_penalty"]) +@pytest.mark.parametrize("value", [-2.1, 2.1]) +def test_penalties_reject_values_outside_mistral_range(penalty_name: str, value: float): + with pytest.raises(ValidationError): + MistralAIChatPromptExecutionSettings(**{penalty_name: value}) + + +@pytest.mark.parametrize("n", [1, 2]) +def test_n_accepts_positive_values(n: int): + settings = MistralAIChatPromptExecutionSettings(n=n) + assert settings.prepare_settings_dict()["n"] == n + + +def test_n_rejects_zero(): + with pytest.raises(ValidationError): + MistralAIChatPromptExecutionSettings(n=0) + + +def test_from_prompt_execution_settings_with_zero_penalties(): + settings = PromptExecutionSettings( + service_id="test_service", + extension_data={"max_tokens": 256, "presence_penalty": 0, "frequency_penalty": 0, "n": 1}, + ) + chat_settings = MistralAIChatPromptExecutionSettings.from_prompt_execution_settings(settings) + assert chat_settings.presence_penalty == 0 + assert chat_settings.frequency_penalty == 0 + assert chat_settings.n == 1