From 15454a5b116428fd0f55ddc26482b3cf863cb5ee Mon Sep 17 00:00:00 2001 From: Qiming Bao Date: Sat, 7 Nov 2026 00:37:31 +0000 Subject: [PATCH] Python: Allow useful repetition_penalty and length_penalty values in OnnxGenAIPromptExecutionSettings Both fields were limited to [0, 1]. In onnxruntime-genai repetition_penalty 1.0 means no penalty and values above 1.0 penalize repeated tokens (positive logits are divided by it, negative ones multiplied), so the useful values were rejected while values below 1.0, which encourage repetition, were accepted. length_penalty is the exponent of the beam-search length normalization and may be any float. Require repetition_penalty > 0 and leave length_penalty unconstrained, matching onnxruntime-genai, which does not validate either value. --- .../onnx_gen_ai_prompt_execution_settings.py | 4 ++-- .../test_onnx_prompt_execution_settings.py | 22 +++++++++++++++++++ 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/python/semantic_kernel/connectors/ai/onnx/onnx_gen_ai_prompt_execution_settings.py b/python/semantic_kernel/connectors/ai/onnx/onnx_gen_ai_prompt_execution_settings.py index 75c3f29699ff..76d68aaa19e3 100644 --- a/python/semantic_kernel/connectors/ai/onnx/onnx_gen_ai_prompt_execution_settings.py +++ b/python/semantic_kernel/connectors/ai/onnx/onnx_gen_ai_prompt_execution_settings.py @@ -14,14 +14,14 @@ class OnnxGenAIPromptExecutionSettings(PromptExecutionSettings): diversity_penalty: Annotated[float | None, Field(ge=0.0, le=1.0)] = None do_sample: bool = False early_stopping: bool = True - length_penalty: Annotated[float | None, Field(ge=0.0, le=1.0)] = None + length_penalty: float | None = None max_length: Annotated[int, Field(gt=0)] = 3072 min_length: Annotated[int | None, Field(gt=0)] = None no_repeat_ngram_size: int = 0 num_beams: Annotated[int | None, Field(gt=0)] = None num_return_sequences: Annotated[int | None, Field(gt=0)] = None past_present_share_buffer: int = True - repetition_penalty: Annotated[float | None, Field(ge=0.0, le=1.0)] = None + repetition_penalty: Annotated[float | None, Field(gt=0.0)] = None temperature: Annotated[float | None, Field(ge=0.0, le=2.0)] = None top_k: Annotated[int | None, Field(gt=0)] = None top_p: Annotated[float | None, Field(ge=0.0, le=1.0)] = None diff --git a/python/tests/unit/connectors/ai/onnx/test_onnx_prompt_execution_settings.py b/python/tests/unit/connectors/ai/onnx/test_onnx_prompt_execution_settings.py index 3d6942ecb8a5..dbff90c39730 100644 --- a/python/tests/unit/connectors/ai/onnx/test_onnx_prompt_execution_settings.py +++ b/python/tests/unit/connectors/ai/onnx/test_onnx_prompt_execution_settings.py @@ -82,3 +82,25 @@ def test_create_options_with_wrong_parameter(): "max_length": 128, }, ) + + +@pytest.mark.parametrize("repetition_penalty", [0.5, 1.0, 1.1, 1.5, 2.0]) +def test_repetition_penalty_accepts_positive_values(repetition_penalty: float): + # onnxruntime-genai: 1.0 means no penalty, values above 1.0 penalize repeated tokens. + settings = OnnxGenAIPromptExecutionSettings(repetition_penalty=repetition_penalty) + assert settings.prepare_settings_dict()["repetition_penalty"] == repetition_penalty + + +@pytest.mark.parametrize("repetition_penalty", [0.0, -1.0]) +def test_repetition_penalty_rejects_non_positive_values(repetition_penalty: float): + # The penalty divides positive logits, so it must be greater than 0. + with pytest.raises(ValidationError): + OnnxGenAIPromptExecutionSettings(repetition_penalty=repetition_penalty) + + +@pytest.mark.parametrize("length_penalty", [-1.0, -0.5, 0.0, 1.0, 1.5, 2.0]) +def test_length_penalty_accepts_values_outside_zero_one(length_penalty: float): + # onnxruntime-genai uses length_penalty as an exponent in beam search: > 0.0 promotes longer + # sequences, < 0.0 promotes shorter ones. + settings = OnnxGenAIPromptExecutionSettings(length_penalty=length_penalty) + assert settings.prepare_settings_dict()["length_penalty"] == length_penalty