From 78578e33b8525be7da840158251c9e819d235ea7 Mon Sep 17 00:00:00 2001 From: Hardik Kaurani Date: Mon, 2 Nov 2026 19:50:59 +0530 Subject: [PATCH] fix(python): return NotImplemented for unsupported operands in CompletionUsage.__add__ --- python/semantic_kernel/connectors/ai/completion_usage.py | 5 ++++- .../unit/connectors/ai/test_completion_token_usage.py | 9 +++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/python/semantic_kernel/connectors/ai/completion_usage.py b/python/semantic_kernel/connectors/ai/completion_usage.py index 6f8af8fb9218..2b0c1e97a4e8 100644 --- a/python/semantic_kernel/connectors/ai/completion_usage.py +++ b/python/semantic_kernel/connectors/ai/completion_usage.py @@ -1,5 +1,6 @@ # Copyright (c) Microsoft. All rights reserved. +from typing import Any from openai.types import CompletionUsage as OpenAICompletionUsage from openai.types.completion_usage import CompletionTokensDetails, PromptTokensDetails @@ -29,8 +30,10 @@ def from_openai(cls, openai_completion_usage: OpenAICompletionUsage): else None, ) - def __add__(self, other: "CompletionUsage") -> "CompletionUsage": + def __add__(self, other: Any) -> "CompletionUsage": """Combine two CompletionUsage instances by summing their token counts.""" + if not isinstance(other, CompletionUsage): + return NotImplemented def _merge_details(cls, a, b): """Merge two details objects by summing their fields.""" diff --git a/python/tests/unit/connectors/ai/test_completion_token_usage.py b/python/tests/unit/connectors/ai/test_completion_token_usage.py index 95fb74dca346..10a85baa00ae 100644 --- a/python/tests/unit/connectors/ai/test_completion_token_usage.py +++ b/python/tests/unit/connectors/ai/test_completion_token_usage.py @@ -1,5 +1,7 @@ # Copyright (c) Microsoft. All rights reserved. +import pytest + from semantic_kernel.connectors.ai.completion_usage import CompletionUsage @@ -41,3 +43,10 @@ def test_completion_usage_empty() -> None: # Check that the total prompt tokens and completion tokens are None assert total_usage.prompt_tokens == 5 assert total_usage.completion_tokens == 0 + + +def test_completion_usage_invalid_add() -> None: + """Test adding unsupported types raises TypeError.""" + usage = CompletionUsage(prompt_tokens=10, completion_tokens=20) + with pytest.raises(TypeError): + _ = usage + 5