Python: Updates (#11371)

### Motivation and Context

Some code cleanup. 

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

### Description

Some code cleanup. 

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [X] The code builds clean without any errors or warnings
- [X] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [X] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄

Author: moonbox3

.github/workflows/generate-pr-description.yml

@@ -17,7 +17,7 @@ jobs:
         id: comment-branch
 
       - name: Set latest commit status as pending
-        uses: myrotvorets/set-commit-status-action@master
+        uses: myrotvorets/set-commit-status-action@v2.0.1
         with:
           sha: ${{ steps.comment-branch.outputs.head_sha }}
           token: ${{ secrets.GITHUB_TOKEN }}
@@ -36,7 +36,7 @@ jobs:
           AZURE_OPENAI_API_KEY: ${{ secrets.AZUREOPENAI__APIKEY }}
 
       - name: Set latest commit status as ${{ job.status }}
-        uses: myrotvorets/set-commit-status-action@master
+        uses: myrotvorets/set-commit-status-action@v2.0.1
         if: always()
         with:
           sha: ${{ steps.comment-branch.outputs.head_sha }}

.github/workflows/python-integration-tests.yml

@@ -533,7 +533,7 @@ jobs:
           script: core.setFailed('Integration Tests Cancelled!')
 
       - name: Microsoft Teams Notification
-        uses: skitionek/notify-microsoft-teams@master
+        uses: skitionek/notify-microsoft-teams@v1.0.8
         if: github.ref == 'refs/heads/main' && github.event_name != 'pull_request'
         with:
           webhook_url: ${{ secrets.MSTEAMS_WEBHOOK }}
@@ -543,7 +543,7 @@ jobs:
           title: "{title: ` ${{ env.run_type }}: ${{ env.date }} `, text: ` ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}`}"
 
       - name: Microsoft Teams Notification (Dry Run)
-        uses: skitionek/notify-microsoft-teams@master
+        uses: skitionek/notify-microsoft-teams@v1.0.8
         if: github.ref != 'refs/heads/main'
         with:
           webhook_url: NONE

.github/workflows/python-test-coverage-report.yml

@@ -39,7 +39,7 @@ jobs:
           echo "PR_NUMBER=$PR_NUMBER" >> $GITHUB_ENV
       - name: Pytest coverage comment
         id: coverageComment
-        uses: MishaKav/pytest-coverage-comment@main
+        uses: MishaKav/pytest-coverage-comment@v1.1.53
         with:
           github-token: ${{ secrets.GH_ACTIONS_PR_WRITE }}
           issue-number: ${{ env.PR_NUMBER }}

.github/workflows/python-unit-tests.yml

@@ -48,7 +48,7 @@ jobs:
         run: uv run --frozen pytest --junitxml=pytest.xml ./tests/unit
       - name: Surface failing tests
         if: ${{ !matrix.experimental }}
-        uses: pmeier/pytest-results-action@main
+        uses: pmeier/pytest-results-action@v0.7.1
         with:
           path: python/pytest.xml
           summary: true

.github/workflows/typos.yaml

@@ -25,7 +25,7 @@ jobs:
           persist-credentials: false
 
       - name: Use custom config file
-        uses: crate-ci/typos@master
+        uses: crate-ci/typos@v1.31.1
         with:
           config: .github/_typos.toml
           write_changes: false

python/pip/README.md

@@ -2,7 +2,7 @@
 name = "semantic-kernel"
 description = "Semantic Kernel Python SDK"
 authors = [{ name = "Microsoft", email = "SK-Support@microsoft.com"}]
-readme = "pip/README.md"
+readme = "README.md"
 # Version read from __version__ field in __init__.py by Flit
 dynamic = ["version"]
 requires-python = ">=3.10"

python/pyproject.toml

@@ -179,7 +179,7 @@ async def invoke(
         cache: "AbstractCache | None" = None,
         max_turns: int | None = None,
         summary_method: str | Callable | None = ConversableAgent.DEFAULT_SUMMARY_METHOD,
-        summary_args: dict | None = {},
+        summary_args: dict | None = None,
         **kwargs: Any,
     ) -> AsyncIterable[AgentResponseItem[ChatMessageContent]]:
         """A direct `invoke` method for the ConversableAgent.
@@ -210,6 +210,9 @@ async def invoke(
         )
         assert thread.id is not None  # nosec
 
+        if summary_args is None:
+            summary_args = {}
+
         if recipient is not None:
             if not isinstance(recipient, AutoGenConversableAgent):
                 raise AgentInvokeException(

python/semantic_kernel/agents/autogen/autogen_conversable_agent.py

@@ -207,18 +207,23 @@ def get_function_call_contents(
     """
     function_call_contents: list[FunctionCallContent] = []
     required_action = getattr(run, "required_action", None)
-    if not required_action or not getattr(required_action, "submit_tool_outputs", False):
+    submit_tool_outputs = getattr(required_action, "submit_tool_outputs", None)
+    if not submit_tool_outputs or not hasattr(submit_tool_outputs, "tool_calls"):
         return function_call_contents
-    for tool_call in required_action.submit_tool_outputs.tool_calls:
-        tool: RunStepFunctionToolCall = tool_call
+    tool_calls = getattr(submit_tool_outputs, "tool_calls", [])
+    if not isinstance(tool_calls, (list, tuple)):
+        return function_call_contents
+    for tool_call in tool_calls:
+        if not isinstance(tool_call, RunStepFunctionToolCall):
+            continue
         fcc = FunctionCallContent(
-            id=tool.id,
-            index=getattr(tool, "index", None),
-            name=tool.function.name,
-            arguments=tool.function.arguments,
+            id=tool_call.id,
+            index=getattr(tool_call, "index", None),
+            name=tool_call.function.name,
+            arguments=tool_call.function.arguments,
         )
         function_call_contents.append(fcc)
-        function_steps[tool.id] = fcc
+        function_steps[tool_call.id] = fcc
     return function_call_contents
 
 

python/semantic_kernel/agents/azure_ai/agent_content_generation.py

@@ -1,6 +1,8 @@
 # Copyright (c) Microsoft. All rights reserved.
 
 
+from unittest.mock import MagicMock
+
 from azure.ai.projects.models import (
     MessageDelta,
     MessageDeltaChunk,
@@ -28,6 +30,7 @@
     RunStepDeltaFunction,
     RunStepDeltaFunctionToolCall,
     RunStepDeltaToolCallObject,
+    RunStepFunctionToolCall,
     ThreadMessage,
 )
 
@@ -256,27 +259,24 @@ def test_get_function_call_contents_no_action():
 
 
 def test_get_function_call_contents_submit_tool_outputs():
-    class FakeFunction:
-        name = "test_function"
-        arguments = {"arg": "val"}
+    fake_function = MagicMock()
+    fake_function.name = "test_function"
+    fake_function.arguments = {"arg": "val"}
+
+    fake_tool_call = MagicMock(spec=RunStepFunctionToolCall)
+    fake_tool_call.id = "tool_id"
+    fake_tool_call.function = fake_function
+
+    run = MagicMock()
+    run.required_action.submit_tool_outputs.tool_calls = [fake_tool_call]
 
-    class FakeToolCall:
-        id = "tool_id"
-        function = FakeFunction()
-
-    run = type(
-        "ThreadRunFake",
-        (),
-        {
-            "required_action": type(
-                "RequiredAction", (), {"submit_tool_outputs": type("FakeSubmit", (), {"tool_calls": [FakeToolCall()]})}
-            )
-        },
-    )()
     function_steps = {}
     fc = get_function_call_contents(run, function_steps)
+
     assert len(fc) == 1
-    assert function_steps["tool_id"].function_name == "test_function"
+    assert fc[0].id == "tool_id"
+    assert fc[0].name == "test_function"
+    assert fc[0].arguments == {"arg": "val"}
 
 
 def test_generate_function_call_content():