Skip to content

Commit 9affeec

Browse files
authored
CHORE: Cleanup unwanted files and correct coveragerc (#186)
### Work Item / Issue Reference <!-- IMPORTANT: Please follow the PR template guidelines below. For mssql-python maintainers: Insert your ADO Work Item ID below (e.g. AB#37452) For external contributors: Insert Github Issue number below (e.g. #149) Only one reference is required - either GitHub issue OR ADO Work Item. --> <!-- mssql-python maintainers: ADO Work Item --> > [AB#38484](https://sqlclientdrivers.visualstudio.com/c6d89619-62de-46a0-8b46-70b92a84d85e/_workitems/edit/38484) <!-- External contributors: GitHub Issue --> > GitHub Issue: #<ISSUE_NUMBER> ------------------------------------------------------------------- ### Summary <!-- Insert your summary of changes below. Minimum 10 characters required. --> This pull request updates the `.coveragerc` configuration to refine which files are omitted from coverage analysis. The main change is broadening the omission list to exclude additional top-level files from coverage reports. Coverage configuration updates: * Added `main.py`, `setup.py`, `bcp_options.py`, and `testing_ddbc_bindings.py` to the omit list in `.coveragerc`, ensuring these files are not included in coverage calculations. <!-- ### PR Title Guide > For feature requests FEAT: (short-description) > For non-feature requests like test case updates, config updates , dependency updates etc CHORE: (short-description) > For Fix requests FIX: (short-description) > For doc update requests DOC: (short-description) > For Formatting, indentation, or styling update STYLE: (short-description) > For Refactor, without any feature changes REFACTOR: (short-description) > For release related changes, without any feature changes RELEASE: #<RELEASE_VERSION> (short-description) ### Contribution Guidelines External contributors: - Create a GitHub issue first: https://github.com/microsoft/mssql-python/issues/new - Link the GitHub issue in the "GitHub Issue" section above - Follow the PR title format and provide a meaningful summary mssql-python maintainers: - Create an ADO Work Item following internal processes - Link the ADO Work Item in the "ADO Work Item" section above - Follow the PR title format and provide a meaningful summary -->
1 parent 83ab8ea commit 9affeec

File tree

6 files changed

+22
-470
lines changed

6 files changed

+22
-470
lines changed

.coveragerc

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
[run]
22
omit =
3-
mssql_python/testing_ddbc_bindings.py
3+
main.py
4+
setup.py
5+
bcp_options.py
46
tests/*
57

68
[report]

.github/workflows/pr-format-check.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,9 @@ jobs:
5757
// Extract the summary content
5858
const summaryContent = summaryMatch[1];
5959
60-
// Remove all HTML comments including the template placeholder
60+
// Remove all HTML comments including unclosed ones (template placeholders)
6161
const contentWithoutComments =
62-
summaryContent.replace(/<!--[\s\S]*?-->/g, '');
62+
summaryContent.replace(/<!--[\s\S]*?(?:-->|$)/g, '');
6363
6464
// Remove whitespace and check if there's actual text content
6565
const trimmedContent = contentWithoutComments.trim();

.gitignore

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
# Ignore all files in the pybind/build directory
2-
mssql_python/pybind/build/
3-
41
# Ignore pycache files and folders
52
__pycache__/
63
**/__pycache__/
@@ -23,6 +20,7 @@ test-*.xml
2320

2421
# Ignore the build & mssql_python.egg-info directories
2522
build/
23+
**/build/
2624
mssql_python.egg-info/
2725

2826
# Python bytecode
@@ -46,4 +44,19 @@ build/
4644
*.swp
4745

4846
# .DS_Store files
49-
.DS_Store
47+
.DS_Store
48+
49+
# wheel files
50+
*.whl
51+
*.tar.gz
52+
*.zip
53+
54+
# Dockerfiles and images (root only)
55+
/Dockerfile*
56+
/docker-compose.yml
57+
/docker-compose.override.yml
58+
/docker-compose.*.yml
59+
60+
# Virtual environments
61+
*venv*/
62+
**/*venv*/
-21.7 MB
Binary file not shown.

mssql_python/msvcp140.dll

-562 KB
Binary file not shown.

0 commit comments

Comments
 (0)