[BUG] Test failure: AcrCommandTests.Should_handle_invalid_subscription_gracefully

[hallipr]

Describe the bug

When run in CI, this live test fails:

https://dev.azure.com/azure-sdk/internal/internal%20Team/_build/results?buildId=5544401&view=logs&j=10c5373b-1204-518d-4816-3b9e801243b4&t=74178588-ddff-5f0d-5175-6e8826faf94e&l=138

Expected behavior

The test should pass because the server should return an error response.

Actual behavior

A success response is returned containing resource details

[xUnit.net 00:00:09.43]         request: {"command":"acr_registry_list","parameters":{"subscription":"invalid-subscription"}}
[xUnit.net 00:00:09.43]         response: {
[xUnit.net 00:00:09.43]           "status": 200,
[xUnit.net 00:00:09.43]           "message": "Success",
[xUnit.net 00:00:09.43]           "results": {
[xUnit.net 00:00:09.43]             "registries": [
[xUnit.net 00:00:09.43]               {
[xUnit.net 00:00:09.43]                 "name": "***",
[xUnit.net 00:00:09.43]                 "location": "westus",
[xUnit.net 00:00:09.43]                 "loginServer": "***",
[xUnit.net 00:00:09.43]                 "skuName": "Basic",
[xUnit.net 00:00:09.43]                 "skuTier": "Basic"
[xUnit.net 00:00:09.43]               },

Reproduction Steps

Run the live tests

Environment

No response

[hallipr]

It appears that we broke this when passing the AZURE_SUBSCRIPTION_ID environment variable in live tests.
If that environment variable exists, then "invalid-subscription" will be considered a placeholder (because the name contains "subscription") and the environment variable will be used instead

[joshfree]

@conniey looks like @jongio added this area but didn't create the tools-ACR label in mcp or mcp-pr.

can you pick up this area, change ownership to you, and double check if anything else is missing on the onboarding process.