Skip to content

Commit 6a4958c

Browse files
committed
addressed tests bugs
1 parent 737a7ef commit 6a4958c

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

servers/Azure.Mcp.Server/CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,10 @@ The Azure MCP Server updates automatically by default whenever a new release com
2424

2525
### Bugs Fixed
2626

27+
- Fixed test failures in CI for SQL commands for `BaseSqlCommand` (--server option) and `BaseDatabaseCommand` (--database option) by using `.AsRequired()` extension method for consistent validation. [[#943](https://github.com/microsoft/mcp/issues/943), [#1013](https://github.com/microsoft/mcp/issues/1013)]
2728
- Avoid spawning child processes per namespace for consolidated mode [[#1002](https://github.com/microsoft/mcp/pull/1002)]
2829
- Improvement to learning experience by ignoring `command` parameter, which resulted in neither learning nor a tool call to happen. Learning is now always invoked when `learn=true` is passed. [[#1057](https://github.com/microsoft/mcp/pull/1057)]
29-
- Adds descriptions to the tools metadata, to ensure enough information is present in the cli to generate docs for metadata. [[#1043](https://github.com/microsoft/mcp/pull/1043)]
30+
- Adds descriptions to the tools metadata, to ensure enough information is present in the cli to generate docs for metadata. [[#1043](https://github.com/microsoft/mcp/pull/1043)]
3031

3132
### Other Changes
3233

tools/Azure.Mcp.Tools.Sql/src/Commands/BaseDatabaseCommand.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
using System.Diagnostics.CodeAnalysis;
55
using Azure.Mcp.Core.Commands;
66
using Azure.Mcp.Core.Extensions;
7+
using Azure.Mcp.Core.Models.Option;
78
using Azure.Mcp.Tools.Sql.Options;
89
using Microsoft.Extensions.Logging;
910

@@ -16,7 +17,7 @@ public abstract class BaseDatabaseCommand<
1617
protected override void RegisterOptions(Command command)
1718
{
1819
base.RegisterOptions(command);
19-
command.Options.Add(SqlOptionDefinitions.Database);
20+
command.Options.Add(SqlOptionDefinitions.Database.AsRequired());
2021
}
2122

2223
protected override TOptions BindOptions(ParseResult parseResult)

tools/Azure.Mcp.Tools.Sql/src/Commands/BaseSqlCommand.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ protected override void RegisterOptions(Command command)
2121
{
2222
base.RegisterOptions(command);
2323
command.Options.Add(OptionDefinitions.Common.ResourceGroup.AsRequired());
24-
command.Options.Add(SqlOptionDefinitions.Server);
24+
command.Options.Add(SqlOptionDefinitions.Server.AsRequired());
2525
}
2626

2727
protected override TOptions BindOptions(ParseResult parseResult)

0 commit comments

Comments
 (0)