Resolved PR feedback

Author: stuartpa

cmd/modern/root/install/mssql-base.go

@@ -314,10 +314,13 @@ func (c *MssqlBase) createContainer(imageName string, contextName string) {
 	endpoint, _ := config.CurrentContext()
 
 	// Connect to the instance as `sa` so we can create a new user
+	//
+	// For Unit Testing we use the Docker Hello World container, which
+	// starts much faster than the SQL Server container!
 	if c.errorLogEntryToWaitFor == "Hello from Docker!" {
-		c.sql = sql.New(true)
+		c.sql = sql.New(sql.SqlOptions{UnitTesting: true})
 	} else {
-		c.sql = sql.New(false)
+		c.sql = sql.New(sql.SqlOptions{})
 	}
 
 	c.sql.Connect(
@@ -330,7 +333,7 @@ func (c *MssqlBase) createContainer(imageName string, contextName string) {
 				Password:          secret.Encode(saPassword, c.encryptPassword),
 			},
 			Name: "sa",
-		}, false)
+		}, sql.ConnectOptions{Interactive: false})
 
 	// Download and restore DB if asked
 	defaultDbAlreadyCreated := false
@@ -492,7 +495,11 @@ EXEC(@sql)`
 	return
 }
 
-func (c *MssqlBase) downloadImage(imageName string, output *output.Output, controller *container.Controller) {
+func (c *MssqlBase) downloadImage(
+	imageName string,
+	output *output.Output,
+	controller *container.Controller,
+) {
 	output.Infof("Downloading %v", imageName)
 	err := controller.EnsureImage(imageName)
 	if err != nil || c.unitTesting {

cmd/modern/root/open/ads.go

@@ -96,7 +96,7 @@ func (c *Ads) launchAds(host string, port int, username string) {
 	}
 
 	tool := tools.NewTool("ads")
-	if !tool.IsInstalled() {
+	if tool.IsInstalled() {
 		output.Fatalf(tool.HowToInstall())
 	} else {
 		_, err := tool.Run(args)

cmd/modern/root/open_test.go

@@ -1,3 +1,6 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT license.
+
 package root
 
 import (

cmd/modern/root/query.go

@@ -56,11 +56,11 @@ func (c *Query) DefineCommand(...cmdparser.CommandOptions) {
 func (c *Query) run() {
 	endpoint, user := config.CurrentContext()
 
-	s := sql.New(false)
+	s := sql.New(sql.SqlOptions{})
 	if c.text == "" {
-		s.Connect(endpoint, user, true)
+		s.Connect(endpoint, user, sql.ConnectOptions{Interactive: true})
 	} else {
-		s.Connect(endpoint, user, false)
+		s.Connect(endpoint, user, sql.ConnectOptions{Interactive: false})
 	}
 
 	s.Query(c.text)

internal/cmdparser/test.go

@@ -1,3 +1,6 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT license.
+
 package cmdparser
 
 import (

internal/credman/credman_linux.go

@@ -1 +1,4 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT license.
+
 package credman

internal/credman/credman_windows.go

@@ -1,3 +1,6 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT license.
+
 // Package credman provides functions for interacting with the Windows Credential
 // Manager API, which allows to read, write, and delete saved credentials on
 // the local machine.

internal/credman/credman_windows_test.go

@@ -1,3 +1,6 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT license.
+
 package credman
 
 import (

internal/credman/types_windows.go

@@ -1,3 +1,6 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT license.
+
 package credman
 
 import (

internal/http/http_test.go

@@ -1,3 +1,6 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT license.
+
 package http
 
 import (