PR feedback

Author: stuartpa

build/azure-pipelines/package-common-test.yml

@@ -32,4 +32,5 @@ steps:
     filePath: '$(Build.SourcesDirectory)\release\windows\msi\scripts\pipeline-test.ps1'
     failOnStderr: true
   env:
-    CLI_VERSION: $(VERSION_TAG)
+    CLI_VERSION: $(VERSION_TAG)
+    

build/azure-pipelines/package-product.yml

@@ -6,7 +6,7 @@ pr: none
 
 variables:
   Build.SourcesCliDirectory: '$(Build.SourcesDirectory)/'
-  wix_download_url: 'https://azdataartifacts.blob.core.windows.net/util/wix314-binaries-mirror.zip'
+  #wix_download_url: 'https://azdataartifacts.blob.core.windows.net/util/wix314-binaries-mirror.zip'
   MSI_OUTPUT_DIR: '$(Build.SourcesCliDirectory)/output'
 
 stages:

release/windows/msi/README.md

@@ -13,34 +13,29 @@ This document provides instructions on creating the MSI.
 
 1. Set the `CLI_VERSION` environment variable
 2. Run `release\windows\msi\scripts\pipeline.cmd`
-3. The unsigned MSI will be in the `.\release\windows\out` folder
+3. The unsigned MSI will be in the `.\output\msi` folder
 
 > **Note:** For `building step 1.` above set both env-vars to the same version-tag for the immediate, this will consolidated in the future.
 
 ## Release Install/Update/Uninstall Steps
 
 > **Note:** Replace `{{HOST}}` and `{{CLI_VERSION}}` with the appropriate values.
 
-### Install SQLCMD TOOLS CLI on Windows
+### Install `Sqlcmd Tools` on Windows
 
-The MSI distributable is used for installing or updating the SQLCMD Tools CLI on Windows. 
+The MSI distributable is used for installing or updating the `Sqlcmd Tools` CLI on Windows. 
 
 [Download the MSI Installer](http://{{HOST}}/sqlcmd-{{CLI_VERSION}}.msi)
 
 When the installer asks if it can make changes to your computer, click the `Yes` box.
 
-### Update
-
-Once removed, [Install SQLCMD Tools CLI on Windows](#install-sqlcmd-on-windows)
-
 ### Uninstall
 
-You can uninstall the SQLCMD CLI from the Windows _Apps and Features_ list. To uninstall:
+You can uninstall the `SqlCmd Tools` from the Windows _Apps and Features_ list. To uninstall:
 
 | Platform      | Instructions                                           |
 | ------------- |--------------------------------------------------------|
 | Windows 10	| Start > Settings > Apps                                |
 | Windows 8     | Start > Control Panel > Programs > Uninstall a program |
 
-
-The program to uninstall is listed as **SQLCMD Tools CLI** . Select this application, then click the `Uninstall` button.
+The program to uninstall is listed as **Sqlcmd Tools** . Select this application, then click the `Uninstall` button.

release/windows/msi/scripts/pipeline-test.ps1

@@ -42,4 +42,4 @@ $env:Path = [System.Environment]::GetEnvironmentVariable("Path", "Machine")
 Write-Output "$env:path"
 
 $sqlcmd = $env:ProgramFiles + "\SqlCmd\Tools\sqlcmd"
-& $sqlcmd --help
+& $sqlcmd --help

release/windows/msi/scripts/pipeline.cmd

@@ -73,4 +73,4 @@ exit /b 1
 
 :END
 exit /b 0
-popd
+popd

release/windows/msi/sqlcmd.wixproj

@@ -44,4 +44,4 @@
     </WixExtension>
   </ItemGroup>
   <Import Project="$(WixTargetsPath)" />
-</Project>
+</Project>