Fix linting: finish the conversion to v9 and flat configs, make lint not silently fail and fix a bunch of type errors (#3932)

* fix lint configuration with new format

* fix repo linting with new configs and version, fixing linting errors as well

* Change files

* fix some styling issues from lint --fix and remove unused ignore files

* Change files

* fix comment

* remove code that would violate security policy

Author: JasonVMo

.eslintignore

@@ -9,7 +9,7 @@
   },
 
   "eslint.enable": true,
-  "eslint.workingDirectories": [{ "mode": "auto" }], // infer working directory based on .eslintrc/package.json location
+  "eslint.workingDirectories": [{ "pattern": "./packages/framework/eslint-config-rules" }], // use the common eslint config file
 
   "explorer.fileNesting.enabled": true,
   "explorer.fileNesting.patterns": {

.eslintrc.json

@@ -1,3 +1,11 @@
 const baseConfig = require('@fluentui-react-native/eslint-config-rules');
 
-module.exports = baseConfig;
+module.exports = [
+  ...baseConfig,
+  {
+    rules: {
+      '@typescript-eslint/no-duplicate-enum-values': 'off',
+      '@typescript-eslint/no-invalid-void-type': 'off',
+    },
+  },
+];

.vscode/settings.json

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-var-requires */
 import React, { useState, useCallback, useMemo } from 'react';
 import { View, Platform, Image } from 'react-native';
 

apps/E2E/eslint.config.js

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-var-requires */
 import React from 'react';
 import { View, Platform, Text } from 'react-native';
 

apps/fluent-tester/src/TestComponents/Badge/BasicBadgeTest.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-var-requires */
 import React, { useCallback, useState } from 'react';
 import { View, StyleSheet, Text } from 'react-native';
 

apps/fluent-tester/src/TestComponents/Badge/CounterBadgeTest.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-var-requires */
 import React, { useState, useCallback } from 'react';
 import { View, Platform, Text } from 'react-native';
 

apps/fluent-tester/src/TestComponents/Badge/PresenceBadgeTest.android.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-var-requires */
 import * as React from 'react';
 import { View } from 'react-native';
 

apps/fluent-tester/src/TestComponents/Badge/PresenceBadgeTest.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-var-requires */
 import * as React from 'react';
 import { Platform, View } from 'react-native';
 
@@ -14,8 +13,6 @@ const CustomizedIconButton = Button.customize({
 });
 
 export const ButtonIconTest_deprecated: React.FunctionComponent = () => {
-  /* eslint-disable @typescript-eslint/no-var-requires */
-
   // SVG-based icons are not available on all platforms yet
   const svgIconsEnabled = ['ios', 'macos', 'win32', 'android'].includes(Platform.OS as string);
   const iconProps = { svgSource: svgProps, width: 20, height: 20 };