Skip to content

Commit b741449

Browse files
committed
Use gRPC status for serverless worker registration
Stop relying on an "accepted" response flag for serverless worker registration. The proto removed the accepted field from OnDemandSandboxActivityWorkerSessionResult and the generated _pb2.py/_pb2.pyi were updated accordingly. The worker now simply invokes connect_serverless_activity_worker and relies on gRPC status/transport behavior instead of checking a boolean, and the changelog documents this change. (Regenerated protobuf offsets in pb2 file as part of the proto change.)
1 parent ad041de commit b741449

5 files changed

Lines changed: 25 additions & 30 deletions

File tree

durabletask-azuremanaged/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
2121
- Removed the serverless worker wakeup HTTP listener because ADC sandbox
2222
workers use outbound DTS registration and do not require an inbound probe
2323
endpoint.
24+
- Changed serverless worker registration to rely on gRPC status instead of an
25+
accepted response flag.
2426

2527
## v1.5.0
2628

durabletask-azuremanaged/durabletask/azuremanaged/extensions/serverless/worker.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -119,11 +119,7 @@ def _run_serverless_registration_loop(self) -> None:
119119
secure_channel=self._secure_channel,
120120
channel_options=self._channel_options)
121121
try:
122-
result = client.connect_serverless_activity_worker(self._registration_messages())
123-
if not result.accepted:
124-
self._logger.warning(
125-
"Serverless activity worker registration was rejected: %s",
126-
result.message)
122+
client.connect_serverless_activity_worker(self._registration_messages())
127123
retry_delay = 1.0
128124
finally:
129125
client.close()

durabletask-azuremanaged/durabletask/azuremanaged/internal/serverless_activities_service.proto

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ message OnDemandSandboxActivityWorkerHeartbeat {
5454
}
5555

5656
message OnDemandSandboxActivityWorkerSessionResult {
57-
bool accepted = 1;
5857
string message = 2;
5958
}
6059

durabletask-azuremanaged/durabletask/azuremanaged/internal/serverless_activities_service_pb2.py

Lines changed: 20 additions & 20 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

durabletask-azuremanaged/durabletask/azuremanaged/internal/serverless_activities_service_pb2.pyi

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,12 +46,10 @@ class OnDemandSandboxActivityWorkerHeartbeat(_message.Message):
4646
def __init__(self, active_activities_count: _Optional[int] = ...) -> None: ...
4747

4848
class OnDemandSandboxActivityWorkerSessionResult(_message.Message):
49-
__slots__ = ("accepted", "message")
50-
ACCEPTED_FIELD_NUMBER: _ClassVar[int]
49+
__slots__ = ("message",)
5150
MESSAGE_FIELD_NUMBER: _ClassVar[int]
52-
accepted: bool
5351
message: str
54-
def __init__(self, accepted: bool = ..., message: _Optional[str] = ...) -> None: ...
52+
def __init__(self, message: _Optional[str] = ...) -> None: ...
5553

5654
class OnDemandSandboxActivityDeclaration(_message.Message):
5755
__slots__ = ("worker_profile_id", "activity_names", "image", "environment_variables", "max_concurrent_activities", "resources", "entrypoint", "cmd")

0 commit comments

Comments
 (0)