save

Author: YunchuWang

durabletask-azuremanaged/durabletask/azuremanaged/preview/sandboxes/worker.py

@@ -249,35 +249,20 @@ def _resolve_dts_sandbox_identifier() -> str:
     grpc.StatusCode.UNKNOWN,
 }
 
-_PERMANENT_FAILED_PRECONDITION_DETAILS = (
-    "worker profile",
-    "registered activit",
-    "max activit",
-    "sandbox identifier",
-    "sandbox id",
-)
+# TODO: Selectively retry FAILED_PRECONDITION only after sandbox worker
+# registration exposes structured, machine-readable transient reasons.
 
 
 def _is_retriable_registration_failure(ex: Exception) -> bool:
     if isinstance(ex, grpc.RpcError):
         status_code = ex.code()
         if status_code in _RETRIABLE_REGISTRATION_STATUS_CODES:
             return True
-        if status_code == grpc.StatusCode.FAILED_PRECONDITION:
-            details = _rpc_error_details(ex).casefold()
-            return not any(
-                detail in details
-                for detail in _PERMANENT_FAILED_PRECONDITION_DETAILS)
         return False
 
     return isinstance(ex, OSError)
 
 
-def _rpc_error_details(ex: grpc.RpcError) -> str:
-    details = ex.details()
-    return details if isinstance(details, str) else ""
-
-
 def _resolve_max_concurrent_activities() -> int:
     value = os.getenv("DTS_SANDBOX_MAX_ACTIVITIES")
     if value is None:

tests/durabletask-azuremanaged/test_sandboxes_extension.py

@@ -755,10 +755,10 @@ def RemoteHello(_ctx, value):
         assert start.start.sandbox_provider == pb.SANDBOX_PROVIDER_KIND_UNSPECIFIED
 
 
-def test_sandbox_registration_retries_transient_failures_only() -> None:
+def test_sandbox_registration_does_not_retry_failed_precondition_without_structured_reasons() -> None:
     assert sandbox_worker._is_retriable_registration_failure(
         _FakeRpcError(grpc.StatusCode.UNAVAILABLE))
-    assert sandbox_worker._is_retriable_registration_failure(
+    assert not sandbox_worker._is_retriable_registration_failure(
         _FakeRpcError(grpc.StatusCode.FAILED_PRECONDITION, "sandbox not ready"))
     assert not sandbox_worker._is_retriable_registration_failure(
         _FakeRpcError(grpc.StatusCode.INVALID_ARGUMENT))