From b7b4656f7e5f400be7b6fb1fe5072d7b5669f7db Mon Sep 17 00:00:00 2001 From: Hardik Kaurani Date: Mon, 2 Nov 2026 00:43:00 +0530 Subject: [PATCH 1/2] fix(workflows): initialize _response_handler_specs to support deferred discovery on Executor Initialize self._response_handler_specs in Executor.__init__ and safely fall back when reading response handler specs so that output_types and workflow_output_types return empty lists instead of raising AttributeError when handler discovery is deferred. Signed-off-by: Hardik Kaurani --- python/packages/core/agent_framework/_workflows/_executor.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/python/packages/core/agent_framework/_workflows/_executor.py b/python/packages/core/agent_framework/_workflows/_executor.py index 7c1a6ffd524..b8c704a6590 100644 --- a/python/packages/core/agent_framework/_workflows/_executor.py +++ b/python/packages/core/agent_framework/_workflows/_executor.py @@ -222,6 +222,7 @@ def __init__( builtin_type[Any] | types.UnionType, Callable[[Any, WorkflowContext[Any, Any]], Awaitable[None]] ] = {} self._handler_specs: list[dict[str, Any]] = [] + self._response_handler_specs: list[dict[str, Any]] = [] if not defer_discovery: self._discover_handlers() @@ -465,7 +466,7 @@ def output_types(self) -> list[type[Any] | types.UnionType]: output_types: set[type[Any] | types.UnionType] = set() # Collect output types from all handlers - for handler_spec in self._handler_specs + self._response_handler_specs: + for handler_spec in self._handler_specs + getattr(self, "_response_handler_specs", []): handler_output_types = handler_spec.get("output_types", []) output_types.update(handler_output_types) @@ -481,7 +482,7 @@ def workflow_output_types(self) -> list[type[Any] | types.UnionType]: output_types: set[type[Any] | types.UnionType] = set() # Collect workflow output types from all handlers - for handler_spec in self._handler_specs + self._response_handler_specs: + for handler_spec in self._handler_specs + getattr(self, "_response_handler_specs", []): handler_workflow_output_types = handler_spec.get("workflow_output_types", []) output_types.update(handler_workflow_output_types) From 1201900206119c0c27bdcac0ccee0cdb24e9c4e6 Mon Sep 17 00:00:00 2001 From: Hardik Kaurani Date: Mon, 2 Nov 2026 00:43:51 +0530 Subject: [PATCH 2/2] test(workflows): verify output_types and workflow_output_types with deferred discovery Add unit test coverage verifying that Executor.output_types and Executor.workflow_output_types safely return empty lists prior to handler discovery when defer_discovery=True, and properly populate once handlers are discovered. Signed-off-by: Hardik Kaurani --- .../tests/workflow/test_request_info_mixin.py | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/python/packages/core/tests/workflow/test_request_info_mixin.py b/python/packages/core/tests/workflow/test_request_info_mixin.py index c53044d37a8..fe90aabb86b 100644 --- a/python/packages/core/tests/workflow/test_request_info_mixin.py +++ b/python/packages/core/tests/workflow/test_request_info_mixin.py @@ -621,6 +621,31 @@ async def handle_str_int(self, original_request: str, response: int, ctx: Workfl # Should return False when _response_handlers attribute doesn't exist assert executor.is_request_supported(str, int) is False assert executor.is_request_supported(dict[str, Any], bool) is False + assert executor.input_types == [] + assert executor.output_types == [] + assert executor.workflow_output_types == [] + + def test_executor_output_types_before_discovery(self): + """Test that output_types and workflow_output_types return empty lists before discovery.""" + + class DeferredExecutor(Executor): + def __init__(self): + super().__init__(id="deferred_executor", defer_discovery=True) + + @handler + async def handle_str(self, message: str, ctx: WorkflowContext[int, float]) -> None: + pass + + executor = DeferredExecutor() + assert executor.input_types == [] + assert executor.output_types == [] + assert executor.workflow_output_types == [] + + # After discovering handlers, types should be populated + executor._discover_handlers() + assert executor.input_types == [str] + assert executor.output_types == [int] + assert executor.workflow_output_types == [float] def test_is_request_supported_with_compatible_types(self): """Test is_request_supported with type-compatible scenarios."""