From 4c18c7cc7752b3b6673336a2103d6a9a7e7d6e48 Mon Sep 17 00:00:00 2001 From: Rudra Pratap SIngh Date: Tue, 26 May 2026 13:19:23 +0530 Subject: [PATCH 1/3] Add DuplexMode parameter to PERF-NETWORK profile and bump version to 3.2.10 Propagates the NTTTCP full-duplex change (#692) to the PERF-NETWORK suite profile, which was missed in the original PR. Adds DuplexMode (default Half) to the Parameters block and threads it through all 11 NTttcp actions (9 TCP + 2 UDP). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- VERSION | 2 +- .../profiles/PERF-NETWORK.json | 36 ++++++++++++------- 2 files changed, 25 insertions(+), 13 deletions(-) diff --git a/VERSION b/VERSION index df4bdc7e53..d6bb32f36f 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -3.2.9 \ No newline at end of file +3.2.10 \ No newline at end of file diff --git a/src/VirtualClient/VirtualClient.Main/profiles/PERF-NETWORK.json b/src/VirtualClient/VirtualClient.Main/profiles/PERF-NETWORK.json index dee04fd8c3..69b0b85f80 100644 --- a/src/VirtualClient/VirtualClient.Main/profiles/PERF-NETWORK.json +++ b/src/VirtualClient/VirtualClient.Main/profiles/PERF-NETWORK.json @@ -18,7 +18,8 @@ "SockPerfDuration": "00:01:00", "ProfilingEnabled": false, "ProfilingMode": "None", - "TestDuration": "00:01:00" + "TestDuration": "00:01:00", + "DuplexMode": "Full" }, "Actions": [ { @@ -35,7 +36,8 @@ "Port": "$.Parameters.NTttcpPort", "ProfilingScenario": "NTttcp_TCP_4K_Buffer_T1", "ProfilingEnabled": "$.Parameters.ProfilingEnabled", - "ProfilingMode": "$.Parameters.ProfilingMode" + "ProfilingMode": "$.Parameters.ProfilingMode", + "DuplexMode": "$.Parameters.DuplexMode" } }, { @@ -52,7 +54,8 @@ "Port": "$.Parameters.NTttcpPort", "ProfilingScenario": "NTttcp_TCP_64K_Buffer_T1", "ProfilingEnabled": "$.Parameters.ProfilingEnabled", - "ProfilingMode": "$.Parameters.ProfilingMode" + "ProfilingMode": "$.Parameters.ProfilingMode", + "DuplexMode": "$.Parameters.DuplexMode" } }, { @@ -69,7 +72,8 @@ "Port": "$.Parameters.NTttcpPort", "ProfilingScenario": "NTttcp_TCP_256K_Buffer_T1", "ProfilingEnabled": "$.Parameters.ProfilingEnabled", - "ProfilingMode": "$.Parameters.ProfilingMode" + "ProfilingMode": "$.Parameters.ProfilingMode", + "DuplexMode": "$.Parameters.DuplexMode" } }, { @@ -86,7 +90,8 @@ "Port": "$.Parameters.NTttcpPort", "ProfilingScenario": "NTttcp_TCP_4K_Buffer_T32", "ProfilingEnabled": "$.Parameters.ProfilingEnabled", - "ProfilingMode": "$.Parameters.ProfilingMode" + "ProfilingMode": "$.Parameters.ProfilingMode", + "DuplexMode": "$.Parameters.DuplexMode" } }, { @@ -103,7 +108,8 @@ "Port": "$.Parameters.NTttcpPort", "ProfilingScenario": "NTttcp_TCP_64K_Buffer_T32", "ProfilingEnabled": "$.Parameters.ProfilingEnabled", - "ProfilingMode": "$.Parameters.ProfilingMode" + "ProfilingMode": "$.Parameters.ProfilingMode", + "DuplexMode": "$.Parameters.DuplexMode" } }, { @@ -120,7 +126,8 @@ "Port": "$.Parameters.NTttcpPort", "ProfilingScenario": "NTttcp_TCP_256K_Buffer_T32", "ProfilingEnabled": "$.Parameters.ProfilingEnabled", - "ProfilingMode": "$.Parameters.ProfilingMode" + "ProfilingMode": "$.Parameters.ProfilingMode", + "DuplexMode": "$.Parameters.DuplexMode" } }, { @@ -137,7 +144,8 @@ "Port": "$.Parameters.NTttcpPort", "ProfilingScenario": "NTttcp_TCP_4K_Buffer_T256", "ProfilingEnabled": "$.Parameters.ProfilingEnabled", - "ProfilingMode": "$.Parameters.ProfilingMode" + "ProfilingMode": "$.Parameters.ProfilingMode", + "DuplexMode": "$.Parameters.DuplexMode" } }, { @@ -154,7 +162,8 @@ "Port": "$.Parameters.NTttcpPort", "ProfilingScenario": "NTttcp_TCP_64K_Buffer_T256", "ProfilingEnabled": "$.Parameters.ProfilingEnabled", - "ProfilingMode": "$.Parameters.ProfilingMode" + "ProfilingMode": "$.Parameters.ProfilingMode", + "DuplexMode": "$.Parameters.DuplexMode" } }, { @@ -171,7 +180,8 @@ "Port": "$.Parameters.NTttcpPort", "ProfilingScenario": "NTttcp_TCP_256K_Buffer_T256", "ProfilingEnabled": "$.Parameters.ProfilingEnabled", - "ProfilingMode": "$.Parameters.ProfilingMode" + "ProfilingMode": "$.Parameters.ProfilingMode", + "DuplexMode": "$.Parameters.DuplexMode" } }, { @@ -188,7 +198,8 @@ "Port": "$.Parameters.NTttcpPort", "ProfilingScenario": "NTttcp_UDP_1400B_Buffer_T1", "ProfilingEnabled": "$.Parameters.ProfilingEnabled", - "ProfilingMode": "$.Parameters.ProfilingMode" + "ProfilingMode": "$.Parameters.ProfilingMode", + "DuplexMode": "$.Parameters.DuplexMode" } }, { @@ -205,7 +216,8 @@ "Port": "$.Parameters.NTttcpPort", "ProfilingScenario": "NTttcp_UDP_1400B_Buffer_T32", "ProfilingEnabled": "$.Parameters.ProfilingEnabled", - "ProfilingMode": "$.Parameters.ProfilingMode" + "ProfilingMode": "$.Parameters.ProfilingMode", + "DuplexMode": "$.Parameters.DuplexMode" } }, { From fe038892e9dac66a30393d33266119e9dd1cf16e Mon Sep 17 00:00:00 2001 From: Rudra Pratap SIngh Date: Wed, 27 May 2026 21:26:53 +0530 Subject: [PATCH 2/3] Rename DuplexMode to NTttcpDuplexMode and set default to Half in PERF-NETWORK profiles - Renamed global parameter 'DuplexMode' -> 'NTttcpDuplexMode' in PERF-NETWORK.json and PERF-NETWORK-NTTTCP.json for consistency and to avoid ambiguity with other tools. - Changed default value from 'Full' back to 'Half' in PERF-NETWORK.json to preserve backward compatibility with historical performance baselines. - All NTttcp executor action references updated to use '$.Parameters.NTttcpDuplexMode'. - The executor-level parameter 'DuplexMode' (on NetworkingWorkloadExecutor) is unchanged. - To run full duplex, pass: --parameters='NTttcpDuplexMode=Full' on the command line. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .../profiles/PERF-NETWORK-NTTTCP.json | 24 +++++++++---------- .../profiles/PERF-NETWORK.json | 24 +++++++++---------- 2 files changed, 24 insertions(+), 24 deletions(-) diff --git a/src/VirtualClient/VirtualClient.Main/profiles/PERF-NETWORK-NTTTCP.json b/src/VirtualClient/VirtualClient.Main/profiles/PERF-NETWORK-NTTTCP.json index 199421addd..1646b4036f 100644 --- a/src/VirtualClient/VirtualClient.Main/profiles/PERF-NETWORK-NTTTCP.json +++ b/src/VirtualClient/VirtualClient.Main/profiles/PERF-NETWORK-NTTTCP.json @@ -12,7 +12,7 @@ "ProfilingEnabled": false, "ProfilingMode": "None", "TestDuration": "00:01:00", - "DuplexMode": "Half" + "NTttcpDuplexMode": "Half" }, "Actions": [ { @@ -30,7 +30,7 @@ "ProfilingScenario": "NTttcp_TCP_4K_Buffer_T1", "ProfilingEnabled": "$.Parameters.ProfilingEnabled", "ProfilingMode": "$.Parameters.ProfilingMode", - "DuplexMode": "$.Parameters.DuplexMode" + "DuplexMode": "$.Parameters.NTttcpDuplexMode" } }, { @@ -48,7 +48,7 @@ "ProfilingScenario": "NTttcp_TCP_64K_Buffer_T1", "ProfilingEnabled": "$.Parameters.ProfilingEnabled", "ProfilingMode": "$.Parameters.ProfilingMode", - "DuplexMode": "$.Parameters.DuplexMode" + "DuplexMode": "$.Parameters.NTttcpDuplexMode" } }, { @@ -66,7 +66,7 @@ "ProfilingScenario": "NTttcp_TCP_256K_Buffer_T1", "ProfilingEnabled": "$.Parameters.ProfilingEnabled", "ProfilingMode": "$.Parameters.ProfilingMode", - "DuplexMode": "$.Parameters.DuplexMode" + "DuplexMode": "$.Parameters.NTttcpDuplexMode" } }, { @@ -84,7 +84,7 @@ "ProfilingScenario": "NTttcp_TCP_4K_Buffer_T32", "ProfilingEnabled": "$.Parameters.ProfilingEnabled", "ProfilingMode": "$.Parameters.ProfilingMode", - "DuplexMode": "$.Parameters.DuplexMode" + "DuplexMode": "$.Parameters.NTttcpDuplexMode" } }, { @@ -102,7 +102,7 @@ "ProfilingScenario": "NTttcp_TCP_64K_Buffer_T32", "ProfilingEnabled": "$.Parameters.ProfilingEnabled", "ProfilingMode": "$.Parameters.ProfilingMode", - "DuplexMode": "$.Parameters.DuplexMode" + "DuplexMode": "$.Parameters.NTttcpDuplexMode" } }, { @@ -120,7 +120,7 @@ "ProfilingScenario": "NTttcp_TCP_256K_Buffer_T32", "ProfilingEnabled": "$.Parameters.ProfilingEnabled", "ProfilingMode": "$.Parameters.ProfilingMode", - "DuplexMode": "$.Parameters.DuplexMode" + "DuplexMode": "$.Parameters.NTttcpDuplexMode" } }, { @@ -138,7 +138,7 @@ "ProfilingScenario": "NTttcp_TCP_4K_Buffer_T256", "ProfilingEnabled": "$.Parameters.ProfilingEnabled", "ProfilingMode": "$.Parameters.ProfilingMode", - "DuplexMode": "$.Parameters.DuplexMode" + "DuplexMode": "$.Parameters.NTttcpDuplexMode" } }, { @@ -156,7 +156,7 @@ "ProfilingScenario": "NTttcp_TCP_64K_Buffer_T256", "ProfilingEnabled": "$.Parameters.ProfilingEnabled", "ProfilingMode": "$.Parameters.ProfilingMode", - "DuplexMode": "$.Parameters.DuplexMode" + "DuplexMode": "$.Parameters.NTttcpDuplexMode" } }, { @@ -174,7 +174,7 @@ "ProfilingScenario": "NTttcp_TCP_256K_Buffer_T256", "ProfilingEnabled": "$.Parameters.ProfilingEnabled", "ProfilingMode": "$.Parameters.ProfilingMode", - "DuplexMode": "$.Parameters.DuplexMode" + "DuplexMode": "$.Parameters.NTttcpDuplexMode" } }, { @@ -192,7 +192,7 @@ "ProfilingScenario": "NTttcp_UDP_1400B_Buffer_T1", "ProfilingEnabled": "$.Parameters.ProfilingEnabled", "ProfilingMode": "$.Parameters.ProfilingMode", - "DuplexMode": "$.Parameters.DuplexMode" + "DuplexMode": "$.Parameters.NTttcpDuplexMode" } }, { @@ -210,7 +210,7 @@ "ProfilingScenario": "NTttcp_UDP_1400B_Buffer_T32", "ProfilingEnabled": "$.Parameters.ProfilingEnabled", "ProfilingMode": "$.Parameters.ProfilingMode", - "DuplexMode": "$.Parameters.DuplexMode" + "DuplexMode": "$.Parameters.NTttcpDuplexMode" } } ], diff --git a/src/VirtualClient/VirtualClient.Main/profiles/PERF-NETWORK.json b/src/VirtualClient/VirtualClient.Main/profiles/PERF-NETWORK.json index 69b0b85f80..ede30c604f 100644 --- a/src/VirtualClient/VirtualClient.Main/profiles/PERF-NETWORK.json +++ b/src/VirtualClient/VirtualClient.Main/profiles/PERF-NETWORK.json @@ -19,7 +19,7 @@ "ProfilingEnabled": false, "ProfilingMode": "None", "TestDuration": "00:01:00", - "DuplexMode": "Full" + "NTttcpDuplexMode": "Half" }, "Actions": [ { @@ -37,7 +37,7 @@ "ProfilingScenario": "NTttcp_TCP_4K_Buffer_T1", "ProfilingEnabled": "$.Parameters.ProfilingEnabled", "ProfilingMode": "$.Parameters.ProfilingMode", - "DuplexMode": "$.Parameters.DuplexMode" + "DuplexMode": "$.Parameters.NTttcpDuplexMode" } }, { @@ -55,7 +55,7 @@ "ProfilingScenario": "NTttcp_TCP_64K_Buffer_T1", "ProfilingEnabled": "$.Parameters.ProfilingEnabled", "ProfilingMode": "$.Parameters.ProfilingMode", - "DuplexMode": "$.Parameters.DuplexMode" + "DuplexMode": "$.Parameters.NTttcpDuplexMode" } }, { @@ -73,7 +73,7 @@ "ProfilingScenario": "NTttcp_TCP_256K_Buffer_T1", "ProfilingEnabled": "$.Parameters.ProfilingEnabled", "ProfilingMode": "$.Parameters.ProfilingMode", - "DuplexMode": "$.Parameters.DuplexMode" + "DuplexMode": "$.Parameters.NTttcpDuplexMode" } }, { @@ -91,7 +91,7 @@ "ProfilingScenario": "NTttcp_TCP_4K_Buffer_T32", "ProfilingEnabled": "$.Parameters.ProfilingEnabled", "ProfilingMode": "$.Parameters.ProfilingMode", - "DuplexMode": "$.Parameters.DuplexMode" + "DuplexMode": "$.Parameters.NTttcpDuplexMode" } }, { @@ -109,7 +109,7 @@ "ProfilingScenario": "NTttcp_TCP_64K_Buffer_T32", "ProfilingEnabled": "$.Parameters.ProfilingEnabled", "ProfilingMode": "$.Parameters.ProfilingMode", - "DuplexMode": "$.Parameters.DuplexMode" + "DuplexMode": "$.Parameters.NTttcpDuplexMode" } }, { @@ -127,7 +127,7 @@ "ProfilingScenario": "NTttcp_TCP_256K_Buffer_T32", "ProfilingEnabled": "$.Parameters.ProfilingEnabled", "ProfilingMode": "$.Parameters.ProfilingMode", - "DuplexMode": "$.Parameters.DuplexMode" + "DuplexMode": "$.Parameters.NTttcpDuplexMode" } }, { @@ -145,7 +145,7 @@ "ProfilingScenario": "NTttcp_TCP_4K_Buffer_T256", "ProfilingEnabled": "$.Parameters.ProfilingEnabled", "ProfilingMode": "$.Parameters.ProfilingMode", - "DuplexMode": "$.Parameters.DuplexMode" + "DuplexMode": "$.Parameters.NTttcpDuplexMode" } }, { @@ -163,7 +163,7 @@ "ProfilingScenario": "NTttcp_TCP_64K_Buffer_T256", "ProfilingEnabled": "$.Parameters.ProfilingEnabled", "ProfilingMode": "$.Parameters.ProfilingMode", - "DuplexMode": "$.Parameters.DuplexMode" + "DuplexMode": "$.Parameters.NTttcpDuplexMode" } }, { @@ -181,7 +181,7 @@ "ProfilingScenario": "NTttcp_TCP_256K_Buffer_T256", "ProfilingEnabled": "$.Parameters.ProfilingEnabled", "ProfilingMode": "$.Parameters.ProfilingMode", - "DuplexMode": "$.Parameters.DuplexMode" + "DuplexMode": "$.Parameters.NTttcpDuplexMode" } }, { @@ -199,7 +199,7 @@ "ProfilingScenario": "NTttcp_UDP_1400B_Buffer_T1", "ProfilingEnabled": "$.Parameters.ProfilingEnabled", "ProfilingMode": "$.Parameters.ProfilingMode", - "DuplexMode": "$.Parameters.DuplexMode" + "DuplexMode": "$.Parameters.NTttcpDuplexMode" } }, { @@ -217,7 +217,7 @@ "ProfilingScenario": "NTttcp_UDP_1400B_Buffer_T32", "ProfilingEnabled": "$.Parameters.ProfilingEnabled", "ProfilingMode": "$.Parameters.ProfilingMode", - "DuplexMode": "$.Parameters.DuplexMode" + "DuplexMode": "$.Parameters.NTttcpDuplexMode" } }, { From d3f5c7faa30d88573ee747ac0f79904e978f77cd Mon Sep 17 00:00:00 2001 From: Rudra Pratap SIngh Date: Wed, 27 May 2026 23:01:38 +0530 Subject: [PATCH 3/3] Bump version to 3.3.1 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/VERSION b/VERSION index f15386a5d5..bea438e9ad 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -3.2.10 +3.3.1