KnowPro.NET: Answer Generation Part 2 (#1768)

* Hooked up end to end Answer Generation
* Anwer Context building
* Entity and Topic merging
* Relevant Knowledge selection
* AnswerTranslator + prompts
* Bug fixes

Author: umeshma

dotnet/typeagent/examples/knowProConsole/TestCommands.cs

@@ -387,7 +387,7 @@ private Command AnswerDef()
     {
         Command cmd = new("kpTestAnswer")
         {
-            Args.Arg<string>("text")
+            Args.Arg<string>("query")
         };
         cmd.TreatUnmatchedTokensAsErrors = false;
         cmd.SetAction(this.AnswerAsync);
@@ -399,6 +399,21 @@ private async Task AnswerAsync(ParseResult args, CancellationToken cancellationT
         IConversation conversation = EnsureConversation();
 
         NamedArgs namedArgs = new NamedArgs(args);
+        string? query = namedArgs.Get<string>("query");
+        if (string.IsNullOrEmpty(query))
+        {
+            return;
+        }
+        IList<AnswerResponse> answers = await conversation.AnswerQuestionAsync(
+            query,
+            null,
+            null,
+            null,
+            null,
+            cancellationToken
+        ).ConfigureAwait(false);
+        KnowProWriter.WriteJson(answers);
+        /*
         AnswerContext context = new AnswerContext();
 
         IList<ConcreteEntity> entities = await conversation.SemanticRefs.GetAllEntitiesAsync(cancellationToken);
@@ -414,6 +429,7 @@ private async Task AnswerAsync(ParseResult args, CancellationToken cancellationT
         context.Messages = messages.Map((m) => new RelevantMessage(m));
         string prompt = context.ToPromptString();
         ConsoleWriter.WriteLine(prompt);
+        */
     }
 
     private IConversation EnsureConversation()

dotnet/typeagent/src/common/Async.cs

@@ -31,8 +31,19 @@ public static async Task<List<TResult>> MapAsync<T, TResult>(
         ArgumentVerify.ThrowIfNull(processor, nameof(processor));
 
         return concurrency <= 1
-            ? await MapSequentialAsync(list, processor, progress, cancellationToken)
-            : await MapConcurrentAsync(list, concurrency, processor, progress, cancellationToken);
+            ? await MapSequentialAsync(
+                list,
+                processor,
+                progress,
+                cancellationToken
+            ).ConfigureAwait(false)
+            : await MapConcurrentAsync(
+                list,
+                concurrency,
+                processor,
+                progress,
+                cancellationToken
+            ).ConfigureAwait(false);
     }
 
     private static async Task<List<TResult>> MapSequentialAsync<T, TResult>(
@@ -47,7 +58,7 @@ CancellationToken cancellationToken
         {
             cancellationToken.ThrowIfCancellationRequested();
 
-            var result = await processor(list[i], cancellationToken);
+            var result = await processor(list[i], cancellationToken).ConfigureAwait(false);
             results.Add(result);
             if (progress is not null)
             {
@@ -75,7 +86,7 @@ CancellationToken cancellationToken
             var batch = list.Slice(startAt, batchSize);
             var tasks = batch.Map<T, Task<TResult>>((t) => processor(t, cancellationToken));
 
-            var batchResults = await Task.WhenAll(tasks);
+            var batchResults = await Task.WhenAll(tasks).ConfigureAwait(false);
 
             results.AddRange(batchResults);
             if (progress is not null)

dotnet/typeagent/src/common/Cache.cs

@@ -180,6 +180,11 @@ public KeyValueCache(IEqualityComparer<TKey> comparer = null)
     public bool Contains(TKey key) => base.ContainsKey(key);
 
     public bool TryGet(TKey key, out TValue value) => base.TryGetValue(key, out value);
+
+    public new void Add(TKey key, TValue value)
+    {
+        TryAdd(key, value);
+    }
 }
 
 public static class Cache

dotnet/typeagent/src/common/StringExtensions.cs

@@ -8,6 +8,16 @@ namespace TypeAgent.Common;
 
 public static partial class StringExtensions
 {
+    public static string Trim(this string text, int maxLength)
+    {
+        text = text.Trim();
+        if (maxLength > 0 && text.Length > maxLength)
+        {
+            text = text[0..maxLength];
+        }
+        return text;
+    }
+
     /// <summary>
     /// Splits an enumerable of strings into chunks, each chunk containing up to maxChunkLength strings and
     /// no more than maxCharsPerChunk total characters. Strings longer than maxCharsPerChunk are truncated.
@@ -67,6 +77,7 @@ public static List<string> LowerAndSort(this List<string> list)
     public static IList<string> SplitLines(this string text, StringSplitOptions options = default)
         => text.Split(s_lineSplitter, options);
 
+    // Split using a Regex
     public static IList<string> Split(this string text, Regex regex, StringSplitOptions options = default)
     {
         ArgumentVerify.ThrowIfNull(regex, nameof(regex));

dotnet/typeagent/src/common/TopNCollection.cs

@@ -3,7 +3,26 @@
 
 namespace TypeAgent.Common;
 
-public class TopNCollection<T>
+public interface ITopNCollection<T>
+{
+    int Count { get; }
+
+    void Add(T item, double score);
+    void Add(IEnumerable<Scored<T>> items);
+    List<Scored<T>> ByRankAndClear();
+}
+
+public static class TopNCollection
+{
+    public static ITopNCollection<T> Create<T>(int maxMatches)
+    {
+        return maxMatches > 0
+            ? new TopNCollection<T>(maxMatches)
+            : new CollectAllCollection<T>();
+    }
+}
+
+public class TopNCollection<T> : ITopNCollection<T>
 {
     private List<Scored<T>>? _items;
     private int _count; // Actual count, since items always ha a
@@ -170,3 +189,36 @@ private void VerifyNotEmpty()
         }
     }
 }
+
+public class CollectAllCollection<T> : ITopNCollection<T>
+{
+    List<Scored<T>>? _items = null;
+
+    public CollectAllCollection()
+    {
+    }
+
+    public int Count => _items is not null
+            ? _items.Count :
+            0;
+
+    public void Add(T item, double score)
+    {
+        _items ??= [];
+        _items.Add(new Scored<T>(item, score));
+    }
+
+    public void Add(IEnumerable<Scored<T>> items)
+    {
+        _items ??= [];
+        _items.AddRange(items);
+    }
+
+    public List<Scored<T>> ByRankAndClear()
+    {
+        var results = _items ?? [];
+        results.Sort();
+        _items = null;
+        return results;
+    }
+}

dotnet/typeagent/src/conversationMemory/Memory.cs

@@ -49,7 +49,7 @@ public async ValueTask<IList<ConversationSearchResult>> SearchAsync(
         }
     }
 
-    public virtual IList<PromptSection>? GetModelInstructions()
+    public virtual IList<IPromptSection>? GetModelInstructions()
     {
         return null;
     }