Add CELL LED blink during connection and fix a bug where some of the event flags in the sandbox where cleared before being processed

Author: M65649

examples/sandbox/sandbox.ino

@@ -25,14 +25,14 @@
 #define MQTT_SUB_TOPIC_FMT "$aws/things/%s/shadow/update/delta"
 #define MQTT_PUB_TOPIC_FMT "%s/sensors"
 
-#define NETWORK_CONN_FLAG                 1 << 0
-#define NETWORK_DISCONN_FLAG              1 << 1
-#define BROKER_CONN_FLAG                  1 << 2
-#define BROKER_DISCONN_FLAG               1 << 3
-#define SEND_HEARTBEAT_FLAG               1 << 4
-#define STOP_PUBLISHING_SENSOR_DATA_FLAG  1 << 5
-#define START_PUBLISHING_SENSOR_DATA_FLAG 1 << 6
-#define SEND_SENSOR_DATA_FLAG             1 << 7
+#define NETWORK_CONN_FLAG                 (1 << 0)
+#define NETWORK_DISCONN_FLAG              (1 << 1)
+#define BROKER_CONN_FLAG                  (1 << 2)
+#define BROKER_DISCONN_FLAG               (1 << 3)
+#define SEND_HEARTBEAT_FLAG               (1 << 4)
+#define STOP_PUBLISHING_SENSOR_DATA_FLAG  (1 << 5)
+#define START_PUBLISHING_SENSOR_DATA_FLAG (1 << 6)
+#define SEND_SENSOR_DATA_FLAG             (1 << 7)
 
 typedef enum {
     NOT_CONNECTED,
@@ -322,8 +322,6 @@ void setup() {
     connectLTE();
 }
 
-unsigned long timeLastCellToggle = millis() + 500;
-
 void loop() {
     // See if there are any messages for the command handler
     if (Serial3.available()) {
@@ -332,13 +330,6 @@ void loop() {
     }
 
     // ----------------------------------------------------------
-    if (state == NOT_CONNECTED) {
-        if ((millis() - timeLastCellToggle) > 500) {
-            LedCtrl.toggle(Led::CELL);
-            timeLastCellToggle = millis();
-        }
-    }
-
     if (event_flags & NETWORK_CONN_FLAG) {
         switch (state) {
         case NOT_CONNECTED:
@@ -372,6 +363,7 @@ void loop() {
         }
 
         event_flags &= ~NETWORK_DISCONN_FLAG;
+
     } else if (event_flags & BROKER_CONN_FLAG) {
 
         switch (state) {

src/lte.cpp

@@ -98,8 +98,8 @@ bool LteClass::begin(const bool print_messages) {
     if (!SequansController.isInitialized()) {
         SequansController.begin();
 
-        // Allow 500ms for boot
-        delay(500);
+        // Allow 50ms for boot
+        delay(50);
     }
 
     SequansController.clearReceiveBuffer();
@@ -159,6 +159,7 @@ bool LteClass::begin(const bool print_messages) {
     }
 
     while (!isConnected()) {
+        LedCtrl.toggle(Led::CELL, true);
         delay(500);
 
         if (print_messages) {
@@ -171,7 +172,7 @@ bool LteClass::begin(const bool print_messages) {
     }
 
     SequansController.clearReceiveBuffer();
-    SequansController.writeCommand(AT_COMMAND_GET_CLOCK);
+    SequansController.retryCommand(AT_COMMAND_GET_CLOCK);
 
     char clock_response[48] = "";
     result =
@@ -210,21 +211,16 @@ bool LteClass::begin(const bool print_messages) {
             // Do manual sync with NTP server
 
             if (print_messages) {
-                Log.info("Did not get time synchronization from operator, "
-                         "doing NTP synchronization. This can take some time.");
+                Log.infof("Did not get time synchronization from operator, "
+                          "doing NTP synchronization.");
             }
 
-            SequansController.clearReceiveBuffer();
             SequansController.registerCallback(NTP_CALLBACK, ntpCallback);
 
             while (!got_ntp_sync) {
                 SequansController.clearReceiveBuffer();
                 SequansController.retryCommand(AT_COMMAND_SYNC_NTP);
 
-                if (print_messages) {
-                    Log.infof("Waiting for NTP sync");
-                }
-
                 while (!got_ntp_callback) {
 
                     if (print_messages) {
@@ -237,10 +233,6 @@ bool LteClass::begin(const bool print_messages) {
                 if (got_ntp_sync) {
                     break;
                 } else {
-                    if (print_messages) {
-                        Log.rawf("\r\n");
-                        Log.info("NTP synchronization timed out, retrying...");
-                    }
                     got_ntp_callback = false;
                 }
             }

src/sequans_controller.cpp

@@ -458,6 +458,9 @@ bool SequansControllerClass::retryCommand(const char *command,
 
     do {
         writeCommand(command);
+
+        // Allow some time for the response
+        _delay_ms(100);
         response = SequansController.readResponse();
 
     } while (response != ResponseResult::OK && retry_count++ < retries);