Clean up fix and add actual test for page[number] computation

Author: jcampbell

flask_rest_jsonapi/pagination.py

@@ -2,6 +2,7 @@
 
 """Helper to create pagination links according to jsonapi specification"""
 
+from __future__ import division
 from six.moves.urllib.parse import urlencode
 from math import ceil
 from copy import copy
@@ -29,7 +30,7 @@ def add_pagination_links(data, object_count, querystring, base_url):
     if querystring.pagination.get('size') != '0' and object_count > 1:
         # compute last link
         page_size = int(querystring.pagination.get('size', 0)) or current_app.config['PAGE_SIZE']
-        last_page = int(ceil(1. * object_count / page_size))
+        last_page = int(ceil(object_count / page_size))
 
         if last_page > 1:
             links['first'] = links['last'] = base_url

tests/test_sqlalchemy_data_layer.py

@@ -330,10 +330,11 @@ def __init__(self, kwargs):
 
 def test_add_pagination_links(app):
     with app.app_context():
-        qs = {'page[number]': '15', 'page[size]': '10'}
+        qs = {'page[number]': '2', 'page[size]': '10'}
         qsm = QSManager(qs, None)
-        add_pagination_links(dict(), 1000, qsm, str())
-
+        pagination_data = dict()
+        add_pagination_links(pagination_data, 43, qsm, str())
+        assert pagination_data['links']['last'] == '?page%5Bsize%5D=10&page%5Bnumber%5D=5'
 
 def test_Node(person_model, person_schema, monkeypatch):
     from copy import deepcopy