Skip to content

Added a log message for PythonActor endpoint error #1925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added a log message for PythonActor endpoint error #1925

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions monarch_hyperactor/src/actor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,9 +957,12 @@ async fn handle_async_endpoint_panic(
actor_id: String,
endpoint: String,
) {
// Clone values before they're moved into attributes
let actor_id_str = actor_id.clone();
let endpoint_str = endpoint.clone();

// Create attributes for metrics with actor_id and endpoint
let attributes =
hyperactor_telemetry::kv_pairs!("actor_id" => actor_id, "endpoint" => endpoint);
let attributes = hyperactor_telemetry::kv_pairs!("actor_id" => actor_id, "method" => endpoint);

// Record the start time for latency measurement
let start_time = std::time::Instant::now();
Expand Down Expand Up @@ -1001,6 +1004,13 @@ async fn handle_async_endpoint_panic(
} {
// Record error and panic metrics
ENDPOINT_ACTOR_ERROR.add(1, attributes);
// use hyperactor tracing to log the required metadata.
tracing::error!(
error = "ActorEndpointError",
method = %endpoint_str,
actor_id = %actor_id_str,
"caught error in async endpoint"
);

panic_sender
.send(PanicFromPy(panic))
Expand Down
Loading