Skip to content

[debug only] disable cuda pt caching allocator #1896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
casteryh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[debug only] disable cuda pt caching allocator #1896

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion monarch_rdma/src/rdma_manager_actor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,11 +267,30 @@ impl Drop for RdmaManagerActor {
}
}

fn cuda_pt_alloc_disabled() -> bool {
static VAL: std::sync::OnceLock<bool> = std::sync::OnceLock::new();
*VAL.get_or_init(
|| match std::env::var("MONARCH_RDMA_CUDA_PT_ALLOC_DISABLED") {
Ok(val) => match val.as_str() {
"1" => true,
"0" => false,
_ => {
tracing::warn!(
"MONARCH_RDMA_CUDA_PT_ALLOC_DISABLED is not set to 0 or 1, defaulting to false"
);
false
}
}
Err(_) => false,
},
)
}

impl RdmaManagerActor {
/// Whether to register all memory regions allocated by the PyTorch CUDA allocator
/// True if both `pt_cuda_alloc` and `mlx5dv_enabled` are true
fn cuda_pt_alloc_enabled(&self) -> bool {
self.pt_cuda_alloc && self.mlx5dv_enabled
self.pt_cuda_alloc && self.mlx5dv_enabled && !cuda_pt_alloc_disabled()
}
/// Get or create a domain and loopback QP for the specified RDMA device
fn get_or_create_device_domain(
Expand Down