logging smoke test (no FD redirection) #1886
Open
+386
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: this diff sets the following defaults for hyperactor-mesh global configuration values: - `MESH_ENABLE_LOG_FORWARDING=false` - `MESH_ENABLE_FILE_CAPTURE=false` - `MESH_TAIL_LOG_LINES=0` the effect of this is to disable log forwarding, prevent allocating resources for log forwarding, no file capture at the hyperactor mesh level (including no "exit tail" capture), in fact, under these defaults there is no interception of child process stdio at all. a [workplace post is planned to announce this change](https://fb.workplace.com/groups/1399849971389924/permalink/1602002844507968/) in default configuration. this diff is built on: D85783397 provide config for enabling/disabling hyperactor-mesh logging interception features, D85919326 for avoiding spinning up `LogForwardActor` meshes when log forwarding is enabled and D85969320 for some detailed testing. Reviewed By: zdevito, vidhyav Differential Revision: D86994420
Summary: `fbinit()` causes the installation of a glog signal handler that prints a stack trace handling `SIGTERM`. calls to `pm.stop()` result in these traces being written to stderr. this diff restores the default signal disposition after the call to `fbinit()` in `bootstrap_main` and the behavior is extinguished. Differential Revision: D87037324
Differential Revision: D87062902
meta-cla
bot
added
the
CLA Signed
|
@shayne-fletcher has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87062902. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D87062902