Skip to content

Commit a25c3ed

Browse files
pzhan9meta-codesync[bot]
authored andcommitted
Bump REMOTE_ALLOCATOR_HEARTBEAT_INTERVAL default value to300secs (#1906)
Summary: Pull Request resolved: #1906 iiuc D84962784 correctly, v1 mesh does not rely on allocator heartbeat anymore. Yet we still get noises from its heartbeat timeout because the default value 5secs was set too aggressive for a large mesh. This diff bumps it to 300secs. Reviewed By: mariusae Differential Revision: D86678878 fbshipit-source-id: e9b51883e102f681923f28f2c416aa4f87f0698e
1 parent f67f81c commit a25c3ed

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

hyperactor/src/config.rs

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -163,12 +163,14 @@ declare_attrs! {
163163
})
164164
pub attr CLEANUP_TIMEOUT: Duration = Duration::from_secs(3);
165165

166-
/// Heartbeat interval for remote allocator
166+
/// Heartbeat interval for remote allocator. We do not rely on this heartbeat
167+
/// anymore in v1, and it should be removed after we finishing the v0
168+
/// deprecation.
167169
@meta(CONFIG = ConfigAttr {
168170
env_name: Some("HYPERACTOR_REMOTE_ALLOCATOR_HEARTBEAT_INTERVAL".to_string()),
169171
py_name: None,
170172
})
171-
pub attr REMOTE_ALLOCATOR_HEARTBEAT_INTERVAL: Duration = Duration::from_secs(5);
173+
pub attr REMOTE_ALLOCATOR_HEARTBEAT_INTERVAL: Duration = Duration::from_secs(300);
172174

173175
/// The default encoding to be used.
174176
@meta(CONFIG = ConfigAttr {
@@ -315,7 +317,7 @@ mod tests {
315317
assert_eq!(config[SPLIT_MAX_BUFFER_SIZE], 5);
316318
assert_eq!(
317319
config[REMOTE_ALLOCATOR_HEARTBEAT_INTERVAL],
318-
Duration::from_secs(5)
320+
Duration::from_secs(300)
319321
);
320322
}
321323

@@ -344,7 +346,7 @@ mod tests {
344346
# export HYPERACTOR_CHANNEL_NET_RX_BUFFER_FULL_CHECK_INTERVAL=5s
345347
# export HYPERACTOR_CHANNEL_MULTIPART=1
346348
# export HYPERACTOR_DEFAULT_ENCODING=serde_multipart
347-
# export HYPERACTOR_REMOTE_ALLOCATOR_HEARTBEAT_INTERVAL=5s
349+
# export HYPERACTOR_REMOTE_ALLOCATOR_HEARTBEAT_INTERVAL=5m
348350
# export HYPERACTOR_STOP_ACTOR_TIMEOUT=10s
349351
# export HYPERACTOR_SPLIT_MAX_BUFFER_SIZE=5
350352
# export HYPERACTOR_MESSAGE_TTL_DEFAULT=64

0 commit comments

Comments
 (0)